On 08/05/2020 09:07, Severin Gehwolf wrote: > Hi, > > Please review this OpenJDK 8u (and 7u) specific patch which fixes a > build failure with > upcoming glibc 2.32 release. This isn't an issue in later JDKs because > headers got cleaned > up by JDK-8167481. Bringing this back into OpenJDK 8u together with > dependencies for this > two liner fix seems overkill and bears more risk. Hence, a point-fix > for OpenJDK 8u (and > possibly 7u). Note that sys/sysctl.h removals are in Linux specific > ifdef branches and sysctl > isn't being used in those files anyway. From a functionality > perspective this should be a no-op. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8244461 > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8244461/01/webrev/ > > Testing: Build on Linux system with preview release of glibc 2.32 now > works, failed before. > > Thoughts? > > Thanks, > Severin >
Looks ok to me and fixed the Fedora build. Approved. -- Andrew :) Senior Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222
signature.asc
Description: OpenPGP digital signature
