Sounds good
Thanks,
Vyom
- Original message -From: Daniel Fuchs Sent by: "net-dev" To: Vyom Tiwari , net-dev , core-libs-dev Cc:Subject: [EXTERNAL] Re: RFR 8238579: HttpsURLConnection drops the timeout and hangs forever in readDate: Sat, Feb 15, 2020 1:11 AM
Hi Vyom,On the surface, your
Hi Vyom,
On the surface, your patch seems reasonable.
I would be more confident if there was a test, but I understand
it might well be one of these noreg-hard issues.
I've put it on my TODO list to import your patch and
try to test it in our test system.
I'll get back to you when I have managed
Hi,
Thanks for the feedback Chris and Alan.
I've added an boolean parameter to the benchmark to allow for the use of
a direct ByteBuffer -- true for direct, false for heap. In interest of
keeping the run time of the benchmark down, I've only included a 'true'
value. However, 'false' can be ad
Looks good to me too.
best regards,
-- daniel
On 14/02/2020 11:57, Patrick Concannon wrote:
Hi,
With further discussion on this benchmark test with Claes off-list, I've
updated the code to use more descriptive names. The updated webrev can
be found below.
http://cr.openjdk.java.net/~pconc
On 2020-02-14 13:01, Chris Hegarty wrote:
http://cr.openjdk.java.net/~pconcannon/8237480/webrevs/webrev.03/
LGTM.
+1
/Claes
> On 14 Feb 2020, at 11:57, Patrick Concannon
> wrote:
>
> Hi,
>
> With further discussion on this benchmark test with Claes off-list, I've
> updated the code to use more descriptive names. The updated webrev can be
> found below.
>
> http://cr.openjdk.java.net/~pconcannon/8237480/webrevs/
Hi,
With further discussion on this benchmark test with Claes off-list, I've
updated the code to use more descriptive names. The updated webrev can
be found below.
http://cr.openjdk.java.net/~pconcannon/8237480/webrevs/webrev.03/
Kind regards,
Patrick
On 13/02/2020 12:54, Patrick Concann
+1
I thought I had a possible fix for this test, but unfortunately
I couldn't manage to push it yesterday. I still need a bit of time
to experiment with several options.
best regards,
-- daniel
On 13/02/2020 23:06, sha.ji...@oracle.com wrote:
Hi,
java/net/httpclient/HandshakeFailureTest.java
Hi Felix,
Thanks for review, writing a test case is not straight forward.
we have to manually inject the write failure, if you see the attached reproducer with the issue it hacks the send native API and inject on the client side which simulates a transient network failure.
Even i was not a
On 13/02/2020 16:53, Chris Hegarty wrote:
:
Did you intentionally use heap byte buffers, or should the test use direct
buffers?
That is a good discussion point as there is a matrix of heap vs. direct,
blocking vs. non-blocking, scatter/gather, ... that could be added to
create more comprehens
10 matches
Mail list logo
