Hi,
With further discussion on this benchmark test with Claes off-list, I've
updated the code to use more descriptive names. The updated webrev can
be found below.
http://cr.openjdk.java.net/~pconcannon/8237480/webrevs/webrev.03/
Kind regards,
Patrick
On 13/02/2020 12:54, Patrick Concannon wrote:
Hi Claes,
Thanks for the feedback.
I've reduced the parameters to 5 i.e. "128", "512", "2048", "8192",
"32768"
I've also removed the main method to conform with the layout of the other
benchmark tests.
You can find the changes in the updated webrev below:
http://cr.openjdk.java.net/~pconcannon/8237480/webrevs/webrev.02/
Kind regards,
Patrick
On 12/02/2020 15:22, Claes Redestad wrote:
Hi,
looks reasonable to me.
To keep default execution times at a manageable level, I'd recommend
excluding some of the 9 values for the size parameter (3-5 values seem
reasonable).
/Claes
On 2020-02-12 16:04, Patrick Concannon wrote:
Hi,
Could someone please review my webrev for JDK-8237480 'Add micros
for DatagramSocket send/receive' ?
This change adds some benchmarks for the DatagramSocket::send and
DatagramSocket::receive methods.
bug: https://bugs.openjdk.java.net/browse/JDK-8237480
webrev:
http://cr.openjdk.java.net/~pconcannon/8237480/webrevs/webrev.01/
Kind regards,
Patrick
