On 05/12/2019 17:17, Patrick Concannon wrote:
Hi,
Thanks for the feedback. I've made those changes now, and you can find
them in the new webrev below.
http://cr.openjdk.java.net/~pconcannon/8233191/webrevs/webrev.01/
I should have been clearer, my comment wasn't about replacing
null with {@c
Looks good to me Patrick!
I see that you have created a CSR at
https://bugs.openjdk.java.net/browse/JDK-8235423
and that looks good to me too.
best regards,
-- daniel
On 05/12/2019 17:17, Patrick Concannon wrote:
Hi,
Thanks for the feedback. I've made those changes now, and you can find
the
Hi,
Thanks for the feedback. I've made those changes now, and you can find
them in the new webrev below.
http://cr.openjdk.java.net/~pconcannon/8233191/webrevs/webrev.01/
Kind regards,
Patrick
On 05/12/2019 16:28, Daniel Fuchs wrote:
On 05/12/2019 16:14, Alan Bateman wrote:
bug: https:/
> On 5 Dec 2019, at 15:50, Patrick Concannon
> wrote:
>
> Hi,
>
>
> Could some please review my fix for issue JDK-8233191 'MulticastSocket
> joinGroup/leaveGroup do not specify their behavior when the outgoing
> interface has not been set'?
>
> This javadoc fix clarifies the behaviour of
On 05/12/2019 16:14, Alan Bateman wrote:
bug: https://bugs.openjdk.java.net/browse/JDK-8233191
webrev: http://cr.openjdk.java.net/~pconcannon/8233191/webrevs/webrev.00/
Looks good, just a minor comment that "If null is given and no
interface ..." might be a bit better "If {@code null}, and no in
On 05/12/2019 15:14, Julia Boes wrote:
Hi,
I wonder however if the links to the deprecated setInterface method
should remain in the two args joinGroup/leaveGroup, since the
behavior is still in effect should you call that method.
Agreed, I updated the webrev and specdiff accordingly.
http
On 05/12/2019 16:01, Daniel Fuchs wrote:
This looks good to me Patrick.
With this fix multicast socket options can be set on DatagramSocket,
except on windows when the DualStackPlainDatagramSocketImpl is used.
DualStackPlainDatagramSocketImpl.java:
246 if (isReusePortAvailable())
247
On 05/12/2019 15:50, Patrick Concannon wrote:
Hi,
Could some please review my fix for issue JDK-8233191 'MulticastSocket
joinGroup/leaveGroup do not specify their behavior when the outgoing
interface has not been set'?
This javadoc fix clarifies the behaviour of 2-arg joinGroup/leaveGroup
On 05/12/2019 15:44, Chris Hegarty wrote:
LGTM.
-Chris.
+1
-- daniel
This looks good to me Patrick.
With this fix multicast socket options can be set on DatagramSocket,
except on windows when the DualStackPlainDatagramSocketImpl is used.
DualStackPlainDatagramSocketImpl.java:
246 if (isReusePortAvailable())
247 options.add(StandardSocketOpti
Hi,
Could some please review my fix for issue JDK-8233191 'MulticastSocket
joinGroup/leaveGroup do not specify their behavior when the outgoing
interface has not been set'?
This javadoc fix clarifies the behaviour of 2-arg joinGroup/leaveGroup
methods when null is passed for the NetworkInte
Looks good to me Julia!
Best regards,
-- daniel
On 05/12/2019 15:14, Julia Boes wrote:
Hi,
I wonder however if the links to the deprecated setInterface method
should remain in the two args joinGroup/leaveGroup, since the
behavior is still in effect should you call that method.
Agreed, I up
> On 5 Dec 2019, at 15:44, Michael McMahon wrote:
>
> Hi,
>
> Could I get the following trivial fix reviewed please. It is included in diff
> form below.
>
> The problem was that a field "charset" was added as part of JDK-8199849, but
> it was
> made protected by mistake instead of private
Hi,
Could some please review my fix for issue JDK-8234148
'DatagramSocket.setOption/getOption/supportedOption should support
multicast options'?
DatagramSocket can be used to send multicast datagrams but it isn't
possible to set multicast options on it. This fix adds multicast socket
optio
Hi,
Could I get the following trivial fix reviewed please. It is included in
diff form below.
The problem was that a field "charset" was added as part of JDK-8199849,
but it was
made protected by mistake instead of private. The fix just makes it private.
There is no regression test for thi
Hi,
I wonder however if the links to the deprecated setInterface method
should remain in the two args joinGroup/leaveGroup, since the
behavior is still in effect should you call that method.
Agreed, I updated the webrev and specdiff accordingly.
http://cr.openjdk.java.net/~jboes/webrevs/82333
> On 4 Dec 2019, at 18:18, Pavel Rappo wrote:
>
> Forwarding to a more relevant mailing list. When answering,
> please remove jdk-dev from the list of recipients.
>
> Thanks.
>
>> Begin forwarded message:
>>
>> From: Chris Mason
>> Subject: HTTP/2 Support in com.sun.net.httpserver?
>> Date
17 matches
Mail list logo
