On 05/12/2019 16:01, Daniel Fuchs wrote:
This looks good to me Patrick. With this fix multicast socket options can be set on DatagramSocket, except on windows when the DualStackPlainDatagramSocketImpl is used.DualStackPlainDatagramSocketImpl.java: 246 if (isReusePortAvailable()) 247 options.add(StandardSocketOptions.SO_REUSEPORT); I believe you can remove these two lines as SO_REUSEPORT is obviously not supported as per line 215.
Good catch, otherwise looks good to me too. -Alan
