RE: RFR[8233860]: java/net/SocketOption/AfterClose.java test incorrectly handles IP_MULTICAST_IF

Hi Patric,   Change looks ok to me, one minor bit i will suggest you to use "List.of()" in place of "new ArrayList<>();". Thanks, Vyom   - Original message -From: Patrick Concannon Sent by: "net-dev" To: Alan Bateman , OpenJDK Network Dev list Cc:Subject: [EXTERNAL] Re: RFR[8233860]: java/n

Re: RFR[8233860]: java/net/SocketOption/AfterClose.java test incorrectly handles IP_MULTICAST_IF

On 13/11/2019 17:41, Patrick Concannon wrote: Hi Alan, Thanks for your feedback. My mistake. I've changed that now in the webrev below. http://cr.openjdk.java.net/~pconcannon/8233860/webrevs/webrev.01/ Looks good.

Re: RFR[8233860]: java/net/SocketOption/AfterClose.java test incorrectly handles IP_MULTICAST_IF

Hi Alan, Thanks for your feedback. My mistake. I've changed that now in the webrev below. http://cr.openjdk.java.net/~pconcannon/8233860/webrevs/webrev.01/ Kind regards, Patrick On 13/11/2019 16:53, Alan Bateman wrote: On 13/11/2019 16:12, Patrick Concannon wrote: Hi, Could someone

Re: RFR[8233860]: java/net/SocketOption/AfterClose.java test incorrectly handles IP_MULTICAST_IF

On 13/11/2019 16:12, Patrick Concannon wrote: Hi, Could someone please review my fix for issue JDK-8233860 'java/net/SocketOption/AfterClose.java test incorrectly handles IP_MULTICAST_IF' ? The test, AfterClose.java, makes a call to setOption() after a socket has been closed to verify t

Re: RFR[8233860]: java/net/SocketOption/AfterClose.java test incorrectly handles IP_MULTICAST_IF

Looks good to me Patrick! best regards, -- daniel On 13/11/2019 16:12, Patrick Concannon wrote: Hi, Could someone please review my fix for issue JDK-8233860 'java/net/SocketOption/AfterClose.java test incorrectly handles IP_MULTICAST_IF' ? The test, AfterClose.java, makes a call to setOp

RFR[8233860]: java/net/SocketOption/AfterClose.java test incorrectly handles IP_MULTICAST_IF

Hi, Could someone please review my fix for issue JDK-8233860 'java/net/SocketOption/AfterClose.java test incorrectly handles IP_MULTICAST_IF' ? The test, AfterClose.java, makes a call to setOption() after a socket has been closed to verify that a SocketException is thrown correctly. Howeve

Re: RFR[8233989]: Create an IPv4 version of java/net/MulticastSocket/SetLoopbackMode.java

Thanks for taking care of that Patrick! The call to IPSupport.throwSkippedExceptionIfNonOperational(); should ensure that the new test will be skipped if IPv4 is not available on the machine, so that looks good to me! best regards, -- daniel On 13/11/2019 11:18, Patrick Concannon wrote: Hi,

RFR[8233989]: Create an IPv4 version of java/net/MulticastSocket/SetLoopbackMode.java

Hi, Could someone please review my fix for issue JDK-8233989 'Create an IPv4 version of java/net/MulticastSocket/SetLoopbackMode.java' ? This fix circumvents the issue by adding a new SetLoopbackModeIPv4 test that calls SetLoopbackMode in IPv4 only mode, and runs only if IPv4 is enabled.