On 13/11/2019 16:12, Patrick Concannon wrote:
Hi,
Could someone please review my fix for issue JDK-8233860
'java/net/SocketOption/AfterClose.java test incorrectly handles
IP_MULTICAST_IF' ?
The test, AfterClose.java, makes a call to setOption() after a socket
has been closed to verify that a SocketException is thrown correctly.
However, the test uses an invalid value (boolean) for the
IP_MULTICAST_IF option invalidating the test.
This fix corrects this error, and passes valid input for the
IP_MULTICAST_IF option (i.e. a NetworkInterface) ensuring that the
test behaves as expected.
bug: https://bugs.openjdk.java.net/browse/JDK-8233860
webrev:
http://cr.openjdk.java.net/~pconcannon/8233860/webrevs/webrev.00/
<http://cr.openjdk.java.net/~pconcannon/8233989/webrevs/webrev.00/>
Looks okay although I assume supportsMulticast should be catching
SocketException rather that Throwable.
-Alan
