(teststabilization) RFR 8230858: Replace wildcard address with loopback or local host in tests - part 23

2019-09-11 Thread Daniel Fuchs
Hi, Please find below a patch for: 8230858: Replace wildcard address with loopback or local host in tests - part 23 https://bugs.openjdk.java.net/browse/JDK-8230858 webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8230858/webrev.00/index.html Some of the tests (3 first files in the we

Re: RFR [XS] : 8230856: Java_java_net_NetworkInterface_getByName0 on unix misses ReleaseStringUTFChars in early return

2019-09-11 Thread Daniel Fuchs
Looks good to me as well Matthias. best regards, -- daniel On 11/09/2019 15:29, Baesken, Matthias wrote: Hello,  please review this small fix . It  adds a missing   ReleaseStringUTFChars in  an early return   case in function  Java_java_net_NetworkInterface_getByName0 (unix only) . Bug/w

RE: RFR [XS] : 8230856: Java_java_net_NetworkInterface_getByName0 on unix misses ReleaseStringUTFChars in early return

2019-09-11 Thread Baesken, Matthias
Thanks for the reviews ! From: Vyom Tewari26 Sent: Mittwoch, 11. September 2019 16:43 To: Baesken, Matthias Cc: net-dev@openjdk.java.net Subject: Re: RFR [XS] : 8230856: Java_java_net_NetworkInterface_getByName0 on unix misses ReleaseStringUTFChars in early return Hi Mathias, Code change look

Re: RFR [XS] : 8230856: Java_java_net_NetworkInterface_getByName0 on unix misses ReleaseStringUTFChars in early return

2019-09-11 Thread Vyom Tewari26
Hi Mathias,   Code change looks OK to me.   Thanks, Vyom   - Original message -From: "Baesken, Matthias" Sent by: "net-dev" To: "net-dev@openjdk.java.net" Cc:Subject: [EXTERNAL] RFR [XS] : 8230856: Java_java_net_NetworkInterface_getByName0 on unix misses ReleaseStringUTFChars in early retur

Re: RFR [XS] : 8230856: Java_java_net_NetworkInterface_getByName0 on unix misses ReleaseStringUTFChars in early return

2019-09-11 Thread Thomas Stüfe
Looks good. Cheers, Thomas On Wed, Sep 11, 2019 at 4:29 PM Baesken, Matthias wrote: > Hello, please review this small fix . > > It adds a missing ReleaseStringUTFChars in an early return case in > function Java_java_net_NetworkInterface_getByName0 > > (unix only) . > > > > Bug/webrev :

RFR [XS] : 8230856: Java_java_net_NetworkInterface_getByName0 on unix misses ReleaseStringUTFChars in early return

2019-09-11 Thread Baesken, Matthias
Hello, please review this small fix . It adds a missing ReleaseStringUTFChars in an early return case in function Java_java_net_NetworkInterface_getByName0 (unix only) . Bug/webrev : https://bugs.openjdk.java.net/browse/JDK-8230856 http://cr.openjdk.java.net/~mbaesken/webrevs/8230856.0