If there's no more comments I will push that shortly...
best regards,
-- daniel
On 03/09/2019 11:01, Daniel Fuchs wrote:
That looks good to me Julia!
best regards,
-- daniel
On 02/09/2019 16:44, Julia Boes wrote:
Hi,
Thanks for the review, Michael and Vyom. I removed server.close() from
> ...
>
> http://cr.openjdk.java.net/~dfuchs/pconcann/8230159/webrevs/webrev.3/
>
LGTM
-Chris.
Thanks Michael!
If I don't receive more comments I will be pushing this
shortly...
best regards,
-- daniel
On 03/09/2019 14:53, Michael McMahon wrote:
Looks fine to me Daniel.
- Michael.
On 02/09/2019, 14:00, Daniel Fuchs wrote:
Hi,
(cc-ing security dev for the changes in
test/jdk/javax/
looks OK to me.
Vyom
- Original message -From: Patrick Concannon To: Vyom Tewari26 , daniel.fu...@oracle.comCc: net-dev@openjdk.java.netSubject: [EXTERNAL] Re: RFR[8230159]: Add test to verify that com.sun.net.httpserver.BasicAuthenticator constructors throw expected exceptionsDate: Wed,
Hey Aleksei,
Good idea. I've made that change, and it can be found in the webrev below.
http://cr.openjdk.java.net/~dfuchs/pconcann/8230132/webrevs/webrev.2/
Kind regards,
Patrick
On 02/09/2019 14:29, Aleks Efimov wrote:
Hey Patrick,
Looks good to me!
You could utilize jdk.test.lib.Platf
Hi Vyom,
Thanks for the feedback. I've made the change as requested, and it can
be found in the new webrev below.
http://cr.openjdk.java.net/~dfuchs/pconcann/8230159/webrevs/webrev.3/
Kind regards,
Patrick
On 03/09/2019 14:31, Vyom Tewari26 wrote:
Hi Patrick,
New test looks good to me, mi
Ping. Anyone willing to review and sponsor, please?
-Jaikiran
On 26/08/19 4:56 PM, Jaikiran Pai wrote:
> Can I please get a review and a sponsor for the patch for
> https://bugs.openjdk.java.net/browse/JDK-8177389. The patch is available
> as a webrev at http://cr.openjdk.java.net/~jpai/webrev/81
