Hey Aleksei,

Good idea. I've made that change, and it can be found in the webrev below.

http://cr.openjdk.java.net/~dfuchs/pconcann/8230132/webrevs/webrev.2/


Kind regards,

Patrick


On 02/09/2019 14:29, Aleks Efimov wrote:
Hey Patrick,

Looks good to me!

You could utilize jdk.test.lib.Platform::isWindows from test library to check if the test is running on Windows platform.

With Best Regards,
Aleksei

On 29/08/2019 16:01, Patrick Concannon wrote:

Hi,

Would it be possible to have my fix for JDK-8230132 reviewed?

java/net/NetworkInterface/NetworkInterfaceRetrievalTests.java was failing intermittently on Windows due to random addresses being returned from the virtual interface "Teredo Tunneling Pseudo-Interface". The fix checks for, and skips, these interfaces - as was done for JDK-8038276. <https://bugs.openjdk.java.net/browse/JDK-8038276>

Further information on this bug can be found here: https://bugs.openjdk.java.net/browse/JDK-8230132

Webrev for fix: http://cr.openjdk.java.net/~dfuchs/pconcann/8230132/webrevs/webrev.1/

Kind regards,
Patrick



Reply via email to