Hi Daniel
I have filed another bug https://bugs.openjdk.java.net/browse/JDK-8227566 to
refine the bug.
And, I tested on Windows 7, the expected exception is raised... I will test on
more platform.
Thanks
Frank
> -Original Message-
> From: Daniel Fuchs [mailto:daniel.fu...@oracle.com]
On 10/07/2019 18:45, Michael McMahon wrote:
Hi Daniel,
I think I prefer the pattern of URL creation where you use URIBuilder
and then toURL() as the final step, rather than toString() and then new
URL(string).
But, it's not a big deal.
Done.
NoLoopbackPackets looks like it could be simplifi
Hi Daniel,
I think I prefer the pattern of URL creation where you use URIBuilder
and then toURL() as the final step, rather than toString() and then new
URL(string).
But, it's not a big deal.
NoLoopbackPackets looks like it could be simplified with try with
resources (line 166)
unless you exp
Hi,
Please find a patch that fixes some of the network test
to stop the using the wildcard issue whenever possible.
8227539: Replace wildcard address with loopback or local host in
tests - part 20
https://bugs.openjdk.java.net/browse/JDK-8227539
webrev:
http://cr.openjdk.java.net/~dfuc
Hi Franck, Vyom,
On 10/07/2019 08:34, Vyom Tewari26 wrote:
that's what i suspected, but test is passing at my local env even after
i changes the permission to 733.
Vyom
Argh!
Of course, the test should ideally throw an AssertionError if
the expected exception is not raised.
And you will dis
Hi Michael,
This looks good to me.
Please trivially update the copyright years before pushing.
best regards,
-- daniel
On 09/07/2019 12:59, Michael McMahon wrote:
Could I get the following small doc clarification reviewed please?
http://cr.openjdk.java.net/~michaelm/8225479/webrev.1/
Thanks
Hi,
Your changes specific to this issue looks good and after your change directory is getting deleted on Windows as well.
DirPermissionDenied.java is running successfully with 733 permission may be a separate issue.
Thanks,
Vyom
- Original message -From: "Frank Yuan" To: "'Vyom Te
IOException is expected by set 333 permission, please read
https://bugs.openjdk.java.net/browse/JDK-6977851
Anyway, please note this patch is to fix the directory was not cleaned after
test completed to run.
Thanks
Frank
From: Vyom Tewari26 [mailto:vtewa...@in.ibm.com]
Sent: Wednesd