Re: RFR [14] 8226303: Test convenience reactive primitives from java.net.http with RS TCK

2019-07-02 Thread Pavel Rappo
> On 2 Jul 2019, at 13:46, Daniel Fuchs wrote: > > Thanks for doing that! LGTM. I've pushed the change http://hg.openjdk.java.net/jdk/jdk/rev/3ae57bbf9585 For the record. In addition to what we've discussed I had to fix the TCK source by making it compliant with jcheck. That extra fix comp

Re: RFR [14] 8226303: Test convenience reactive primitives from java.net.http with RS TCK

2019-07-02 Thread Daniel Fuchs
Hi Pavel, On 02/07/2019 12:05, Pavel Rappo wrote: Daniel, If you are okay with this, I will push the change with you as a reviewer after adding this to the TckDriver.java: Tests 1. The purpose of each test should be easily digestible. The name of the test is derived from the very entity

Re: RFR [14] 8226303: Test convenience reactive primitives from java.net.http with RS TCK

2019-07-02 Thread Pavel Rappo
Daniel, If you are okay with this, I will push the change with you as a reviewer after adding this to the TckDriver.java: Tests 1. The purpose of each test should be easily digestible. The name of the test is derived from the very entity the test exercises. For example, the BodyPublis