Hi Pavel,
On 02/07/2019 12:05, Pavel Rappo wrote:
Daniel,
If you are okay with this, I will push the change with you as a reviewer after
adding this to the TckDriver.java:
#### Tests
1. The purpose of each test should be easily digestible. The name of the
test is derived from the very entity the test exercises. For example,
the BodyPublishersOfFile test exercises the BodyPublisher obtained
by calling BodyPublishers.ofFile(Path)
the BodySubscribersOfFile test exercises the BodySubscriber obtained
by calling BodySubscribers.ofFile(Path)
Thanks for doing that! LGTM.
best regards,
-- daniel
On 1 Jul 2019, at 12:19, Pavel Rappo <pavel.ra...@oracle.com> wrote:
On 25 Jun 2019, at 15:27, Daniel Fuchs <daniel.fu...@oracle.com> wrote:
Would it be possible to add a one-line comment at the beginning
of each test to explain what they are testing?
Thanks for taking a look at that!
To be honest that's one of those cases where adding what you ask is like putting
a sticker with a word "cat" on a cat's forehead.
First of all, each test is very small and digestible. One won't go and just fix
it without understanding the mechanics of the TCK anyway. Secondly, their (I was
hoping) self-descriptive names are derived from the very entity they test.
I can add some extra verbiage to the TckDriver.java instead, if you think it
could be helpful.
-Pavel
