Re: RFR 8216417: cleanup of IPv6 scope-id handling

Hi Michael, AbstractPlainDatagramSocketImpl.java: in `send` maybe the packet should only be recreated if the address is different. best regards, -- daniel On 10/06/2019 15:18, Michael McMahon wrote: Hi, Could I get the following change to net/nio reviewed please? It is a general cleanup of

Re: RFR 8216417: cleanup of IPv6 scope-id handling

On 10/06/2019 15:18, Michael McMahon wrote: Hi, Could I get the following change to net/nio reviewed please? It is a general cleanup of IPv6 scope_id handling which removes a lot of native code trickery (mostly in Linux) and simplifies the handling of scope_ids such that: a) when binding/con

RFR 8216417: cleanup of IPv6 scope-id handling

Hi, Could I get the following change to net/nio reviewed please? It is a general cleanup of IPv6 scope_id handling which removes a lot of native code trickery (mostly in Linux) and simplifies the handling of scope_ids such that: a) when binding/connecting/sending to a link-local address on the

Re: [teststabilization] RFR: 8224865: Replace wildcard address with loopback or local host in tests - part 13

Hi Vyom, On 10/06/2019 15:03, Vyom Tewari26 wrote: Changes looks good to me, although it is different issue, i can see lots of '.*' in import statements, as you are touching these files did you considered removing them ?. Well - no - I didn't. The changes have been pushed already. best regar

[teststabilization] RFR: 8225512: Replace wildcard address with loopback or local host in tests - part 15

Hi, Please find below a fix for: 8225512: Replace wildcard address with loopback or local host in tests - part 15 https://bugs.openjdk.java.net/browse/JDK-8225512 http://cr.openjdk.java.net/~dfuchs/webrev_8225512/webrev.00/ This patch replace the use of wildcard by the loopback in com

Re: [teststabilization] RFR: 8224865: Replace wildcard address with loopback or local host in tests - part 13

Hi Daniel,   Changes looks good to me, although it is different issue, i can see lots of '.*' in import statements, as you are touching these files did you considered removing them ?.   Thanks, Vyom   - Original message -From: Daniel Fuchs Sent by: "net-dev" To: OpenJDK Network Dev list Cc:

Re: [teststabilization] RFR: 8224865: Replace wildcard address with loopback or local host in tests - part 13

> On 7 Jun 2019, at 12:24, Daniel Fuchs wrote: > > Hi, > > Please find below a fix for: > > 8224865: Replace wildcard address with loopback or local host in > tests - part 13 > https://bugs.openjdk.java.net/browse/JDK-8224865 > > webrev: > http://cr.openjdk.java.net/~dfuchs/webrev_822

[ipv6] Re: SocketAddress.toString() and RFC 2732

Thanks for reporting this Chris, and Alan for filing an issue to track it. That issue is: https://bugs.openjdk.java.net/browse/JDK-8225499 ( which links to the IPv6-only work that Alan mentioned ) -Chris. > On 8 Jun 2019, at 07:38, Alan Bateman wrote: > > On 07/06/2019 19:46, Chris wrote: