Re: [ipv6]: 8224081: SOCKS v4 doesn't work with IPv6

On 5/24/19 4:56 PM, Sean Mullan wrote: On 5/23/19 8:14 PM, Arthur Eubanks wrote: Ping on a review from security-dev. On Fri, May 17, 2019 at 9:53 AM Chris Hegarty mailto:chris.hega...@oracle.com>> wrote:     Arthur,     On 17 May 2019, at 17:50, Arthur Eubanks mailto:aeuba...@google.com>>

Re: [ipv6]: 8224081: SOCKS v4 doesn't work with IPv6

On Fri, May 24, 2019 at 1:56 PM Sean Mullan wrote: > On 5/23/19 8:14 PM, Arthur Eubanks wrote: > > Ping on a review from security-dev. > > > > On Fri, May 17, 2019 at 9:53 AM Chris Hegarty > > wrote: > > > > Arthur, > > > >> On 17 May 2019, at 17:50, Arth

Re: [ipv6]: 8224081: SOCKS v4 doesn't work with IPv6

On 5/23/19 8:14 PM, Arthur Eubanks wrote: Ping on a review from security-dev. On Fri, May 17, 2019 at 9:53 AM Chris Hegarty > wrote: Arthur, On 17 May 2019, at 17:50, Arthur Eubanks mailto:aeuba...@google.com>> wrote: Looks good. Tri

[teststabilization] RFR: 8224761: Replace wildcard address with loopback or local host in tests - part 12

Hi, Please find a patch that fixes a batch of tests that have been observed to fail intermittently. Usual symptoms, usual probable cause, and usual recipe: 8224761: Replace wildcard address with loopback or local host in tests - part 12 https://bugs.openjdk.java.net/browse/JDK-8224761

Re: [teststabilization] RFR: 8224603: Replace wildcard address with loopback or local host in tests - part 11

Hi Vyom, On 24/05/2019 15:37, Vyom Tiwari wrote: Hi Daniel, SocksProxyVersion.java is one of them my local repo it is showing (Copyright (c) 2011, 2015, Oracle and/or its). No, that one is correct. But BadProxySelector.java was missing it. Thanks for catching that. I was talking do we need

Re: [teststabilization] RFR: 8224603: Replace wildcard address with loopback or local host in tests - part 11

Hi Daniel, SocksProxyVersion.java is one of them my local repo it is showing (Copyright (c) 2011, 2015, Oracle and/or its). I was talking do we need both(printing message on System.err & throwing exception), as you already explain throwing exception is required but do we need same error message (

Re: [teststabilization] RFR: 8224603: Replace wildcard address with loopback or local host in tests - part 11

Hi Vyom, On 24/05/2019 14:36, Vyom Tiwari wrote: Hi Daniel, Overall changes looks good to me, please update the copy write date that you missed in couple of files. Which files did I miss? In "TestHttpServer.java"  we are printing error message on System.err and throwing the RuntimeException

Re: [teststabilization] RFR: 8224603: Replace wildcard address with loopback or local host in tests - part 11

Hi Daniel, Overall changes looks good to me, please update the copy write date that you missed in couple of files. In "TestHttpServer.java" we are printing error message on System.err and throwing the RuntimeException both as below, do you think we need both ? System.err.println ("Server could n

Re: [teststabilization] RFR: 8224603: Replace wildcard address with loopback or local host in tests - part 11

On 22/05/2019 18:35, Daniel Fuchs wrote: Hi, Please find below a patch for the next batch of tests that have been observed failing intermittently. JBS: https://bugs.openjdk.java.net/browse/JDK-8224603 webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8224603/webrev.00/ Looks ok to me Danie

Re: RFR 8224477 [13] java.net.Socket::setOption - implementation mismatch to spec

On 23/05/2019 17:32, Chris Hegarty wrote: Thank you Alan, I believe that I addressed all your comments and suggestions. Additionally, while here I noticed an issue where these methods were not always consistent with their spec to throw IOException when the socket has been closed. https://cr.op