On 27/03/2019 17:02, Daniel Fuchs wrote:
...
Webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8221395/webrev.00/
Looks good. Trivially, add the bugId to @bug in the test.
-Chris.
Fix looks good to me Daniel. Good catch.
- Michael.
On 27/03/2019, 17:02, Daniel Fuchs wrote:
Hi,
Please find below a fix for:
8221395: HttpClient leaving connections in CLOSE_WAIT state until
Java process ends
https://bugs.openjdk.java.net/browse/JDK-8221395
Webrev:
http://cr.openj
>
> 1) The following test fails with this change, when run on an IPv6-only
> environment. The reason is that it contains a certificate that has
> the IPv4 loopback address, 127.0.0.1.
>
>
> sun/net/www/protocol/https/HttpsURLConnection/IPAddressIPIdentities.java
>
> Caused by: java.secu
Arthur,
On 27/03/2019 15:53, Arthur Eubanks wrote:
Done: http://cr.openjdk.java.net/~aeubanks/8220575/webrev.04/
1) The following test fails with this change, when run on an IPv6-only
environment. The reason is that it contains a certificate that has
the IPv4 loopback address, 127
Hi,
Please find below a fix for:
8221395: HttpClient leaving connections in CLOSE_WAIT state until
Java process ends
https://bugs.openjdk.java.net/browse/JDK-8221395
Webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8221395/webrev.00/
HttpConnection has a high level isOpen() accessor
> 1) test/jdk/java/net/ResponseCache/Test2.java
>
> 83 url = URIBuilder.newBuilder()
> 84 .scheme("http")
> 85 .loopback()
> 86 .port(port)
> 87 .path("/test/foo")
> 88 .toURLUnchecked();
> 89
Arthur,
On 26/03/2019 22:07, Arthur Eubanks wrote:
Forgot to add URIBuilder, fixed in:
http://cr.openjdk.java.net/~aeubanks/8220575/webrev.03/index.html
I am happy with this. Just a few minor comments.
1) test/jdk/java/net/ResponseCache/Test2.java
83 url = URIBuilder.newBuilder()