Arthur, On 26/03/2019 22:07, Arthur Eubanks wrote:
Forgot to add URIBuilder, fixed in: http://cr.openjdk.java.net/~aeubanks/8220575/webrev.03/index.html
I am happy with this. Just a few minor comments. 1) test/jdk/java/net/ResponseCache/Test2.java 83 url = URIBuilder.newBuilder() 84 .scheme("http") 85 .loopback() 86 .port(port) 87 .path("/test/foo") 88 .toURLUnchecked(); 89 System.out.println("URL: " + url); <<<< here Can you please remove the extra indentation on L89. 2) Can you please use the standard four-space indentation in URIBuilder. Otherwise, Reviewed. -Chris.