RE: RFR 8179549: Typo in network properties documentation

2019-03-14 Thread Langer, Christoph
Looks good, +1 /Christoph From: net-dev On Behalf Of Chris Hegarty Sent: Donnerstag, 14. März 2019 17:47 To: net-dev Subject: RFR 8179549: Typo in network properties documentation Trivial typo fix. diff --git a/src/java.base/share/classes/java/net/doc-files/net-properties.html b/src/java.bas

Re: Regarding 8220575: Correctly format test URI's that contain a retrieved IPv6 address

2019-03-14 Thread Chris Hegarty
Arthur, > On 14 Mar 2019, at 17:44, Arthur Eubanks wrote: > > Most of these eventually turn the String into a URL, so using a URL directly > should work? URL constructors will work, but I would prefer to not add any more usages of these than we already have. I plan to start a discussion about

Re: Regarding 8220575: Correctly format test URI's that contain a retrieved IPv6 address

2019-03-14 Thread Arthur Eubanks
Most of these eventually turn the String into a URL, so using a URL directly should work? jshell> URL u = new URL("http", "::1", 9002, "/") u ==> http://[::1]:9002/ jshell> URL u = new URL("http", InetAddress.getLoopbackAddress().getHostAddress(), 9002, "/") u ==> http://127.0.0.1:9002/ jshell> UR

RFR 8179549: Typo in network properties documentation

2019-03-14 Thread Chris Hegarty
Trivial typo fix. diff --git a/src/java.base/share/classes/java/net/doc-files/net-properties.html b/src/java.base/share/classes/java/net/doc-files/net-properties.html --- a/src/java.base/share/classes/java/net/doc-files/net-properties.html +++ b/src/java.base/share/classes/java/net/doc-files/net-

Re: Regarding 8220575: Correctly format test URI's that contain a retrieved IPv6 address

2019-03-14 Thread Chris Hegarty
It's just a hack, but enough to get me started so I can asses some of what is needed to support running the tests on an IPv6-only environment. http://cr.openjdk.java.net/~chegar/ipv6-only-hack/ My /etc/hosts file has entries for `localhost` and the _host_, that return `::1`. This is enough

Re: RFR 8213912: Semantic typo in HttpExchange.java

2019-03-14 Thread Chris Hegarty
Daniel, > On 14 Mar 2019, at 11:10, Daniel Fuchs wrote: > > Hi Chris, > > Thanks for fixing this, it is an important distinction! Thanks for the review. > (and I like John's description of the issue :-)) > > I am wondering though - whether there's a relationship with > this bug, and JDK-8180

Re: RFR 8213912: Semantic typo in HttpExchange.java

2019-03-14 Thread Daniel Fuchs
Hi Chris, Thanks for fixing this, it is an important distinction! (and I like John's description of the issue :-)) I am wondering though - whether there's a relationship with this bug, and JDK-8180754 [1]. best regards, -- daniel [1] https://bugs.openjdk.java.net/browse/JDK-8180754 On 14/03/

RFR 8213912: Semantic typo in HttpExchange.java

2019-03-14 Thread Chris Hegarty
In the class-level description for com.sun.net.httpserver.HttpExchange there is a typo related to the request body input stream, that may cause confusion. It should be fixed. The typical life-cycle of an exchange, as described, should advise the reader that the request body input stream *SHOULD* b