Re: RFR: 8220083: Use InetAddress.getLoopbackAddress() in place of 127.0.0.1 for some tests

Hi Arthur, Changes looks good to me, one minor comment, in HTTPTestServer.java we can avoid new local variable (InetAddress address) . Thanks, Vyom On Tue, Mar 12, 2019 at 10:30 PM Arthur Eubanks wrote: > Thanks for creating the umbrella bug. > > Split long line. > Added the HTTPTestServer.j

Re: RFR: 8220083: Use InetAddress.getLoopbackAddress() in place of 127.0.0.1 for some tests

Arthur, > On 12 Mar 2019, at 17:54, Arthur Eubanks wrote: > > Thanks! > > Just curious, what tests did you run and under what environment? I ran all java/net, sun/net, com/sun/net/, and some nio. I'm have a bit of a hacky environment: a JDK build with IPV6_V6ONLY set to 1, and preferIPv6Addre

Re: RFR: 8220083: Use InetAddress.getLoopbackAddress() in place of 127.0.0.1 for some tests

Thanks! Just curious, what tests did you run and under what environment? On Tue, Mar 12, 2019 at 10:34 AM Chris Hegarty wrote: > Arthur, > > On 12 Mar 2019, at 16:59, Arthur Eubanks wrote: > > Thanks for creating the umbrella bug. > > Split long line. > Added the HTTPTestServer.java and Urgent

Re: RFR: 8220083: Use InetAddress.getLoopbackAddress() in place of 127.0.0.1 for some tests

Arthur, > On 12 Mar 2019, at 16:59, Arthur Eubanks wrote: > > Thanks for creating the umbrella bug. > > Split long line. > Added the HTTPTestServer.java and UrgentDataTest.java changes in Chris's > suggestions. Thanks. > The other 2 involve URI/URLs, and there are a lot of those changes, wil

Re: RFR: 8220083: Use InetAddress.getLoopbackAddress() in place of 127.0.0.1 for some tests

Thanks for creating the umbrella bug. Split long line. Added the HTTPTestServer.java and UrgentDataTest.java changes in Chris's suggestions. The other 2 involve URI/URLs, and there are a lot of those changes, will group them in a later change. PTAL: http://cr.openjdk.java.net/~aeubanks/8220083/we

8220493: Prepare Socket/ServerSocket for alternative platform SocketImpl

We have a branch in the sandbox named "niosocketimpl-branch" with a replacement for the underlying implementation used by java.net.Socket and ServerSocket. I've mentioned this in previous mails [1]. We also have a draft JEP [2]. I'd like to get the changes that allow for the platform Socket

Re: RFR: 8220083: Use InetAddress.getLoopbackAddress() in place of 127.0.0.1 for some tests

Hi Arthur, > On 11 Mar 2019, at 18:14, Arthur Eubanks > wrote: > > Updated copyright years (I asked around, it should be fine), updated commit > message. > http://cr.openjdk.java.net/~aeubanks/8220083/webrev.01 >

Re: RFR: 8220083: Use InetAddress.getLoopbackAddress() in place of 127.0.0.1 for some tests

Hi Arthur, This looks good to me. I have launched the changes in your second webrev through our test system and not observed any regression. I don't know if Chris still has some tests running, but from my standpoint you're good to go! best regards, -- daniel On 11/03/2019 18:14, Arthur Eubanks

Re: RFR 8220480: Typo in java.net.http.HttpResponse.BodySubscriber documentation

On 12/03/2019 09:05, Chris Hegarty wrote: Minor typo in the link target, should be BodySubscribers ( plural ). Looks okay.

RFR 8220480: Typo in java.net.http.HttpResponse.BodySubscriber documentation

Minor typo in the link target, should be BodySubscribers ( plural ). --- a/src/java.net.http/share/classes/java/net/http/HttpResponse.java +++ b/src/java.net.http/share/classes/java/net/http/HttpResponse.java @@ -1,7 +1,7 @@ /* - * Copyright (c) 2015, 2018, Oracle and/or its affiliates. All right