Hi Arthur,

> On 11 Mar 2019, at 18:14, Arthur Eubanks <aeuba...@google.com 
> <mailto:aeuba...@google.com>> wrote:
> 
> Updated copyright years (I asked around, it should be fine), updated commit 
> message.
> http://cr.openjdk.java.net/~aeubanks/8220083/webrev.01 
> <http://cr.openjdk.java.net/~aeubanks/8220083/webrev.01>
This is a welcome improvement to the tests. Reviewed, with some minor
comments and additions below.

It will not be easy to get all the JDK networking tests passing
successfully on IPv6-only environments ( ignoring the other combinations
for now ). But this is a good improvement, and hopefully the start of
a number of changes that add similar incremental improvements. To this
end, I've created an umbrella task, 8220499, to track these test changes
( in one place ), and updated this issue, 8220083, to be a sub-task of
it. Let's add more sub-tasks as needed.

Specific webrev comment:
 * Can you please split the long line in TunnelThroughProxy.java

Suggestion for similar changes while here:
 * http://cr.openjdk.java.net/~chegar/8220083.additional/index.html 
<http://cr.openjdk.java.net/~chegar/8220083.additional/index.html>

-Chris.

Reply via email to