Sorry, one more revision here since I found we could do a little more in
subclasses (use loopback address to avoid possible outside noise), and this
will introduce the test class which extends AsyncCloseTest into webrev, hope
that will be convenient for review, thanks
http://cr.openjdk.java.net
Hi, Daniel
Thanks a lot for your reviewing and comments, revision webrev as below.
http://cr.openjdk.java.net/~xyin/8129310/webrev.01/
Regards,
Chris
> On 15 Nov 2018, at 6:06 PM, Daniel Fuchs wrote:
>
> Hi chris,
>
> There's no reason to make `passed` and `closed` volatile since
> they are
Vyom,
> On 13 Nov 2018, at 12:35, vyom tewari wrote:
>
> Hi Chris,
>
> Thanks for review, please find the latest
> webrev(http://cr.openjdk.java.net/~vtewari/8046500/webrev0.1/index.html)
> where i incorporated your suggestion. Now i am returning the different error
> code(-2) if IP Helper L
Hi chris,
There's no reason to make `passed` and `closed` volatile since
they are private and only accessed from withing synchronized
methods.
On the other hand, reason could now be final.
Otherwise I guess it looks good. I haven't looked at the tests that
use AsyncClose so I trust that you hav
Please review below minor change for java/net/Socket/asyncClose/AsyncClose.java
fails intermittently issue, thanks
From previous failure log, seems lack of enough info to find out root cause,
this change is to enhance a little to base test class AsyncCloseTest with
guessing, even it may not com
