Thanks for the feedback. Made those changes (reverted
src/java.base/linux/native/libnio/fs/LinuxWatchService.c):
diff --git a/make/lib/Lib-jdk.net.gmk b/make/lib/Lib-jdk.net.gmk
--- a/make/lib/Lib-jdk.net.gmk
+++ b/make/lib/Lib-jdk.net.gmk
@@ -35,7 +35,7 @@
CFLAGS := $(CFLAGS_JDKLIB), \
On 17/07/2018 07:33, Andrew Luo wrote:
Great, thanks.
By the way, I do see other places where we use NET_* functions in libnio, but
if you prefer that I duplicate that code instead,
It's okay for the code in libnio/ch to use the NET_* functions. The
issue is the changes to libnio/fs which is t
Great, thanks.
By the way, I do see other places where we use NET_* functions in libnio, but
if you prefer that I duplicate that code instead, I can do that.
By the way, I do see other places where libnio calls into the NET_* functions:
jdk/src/java.base/unix/native/libnio$ grep -F -r --include
Looks fine Chris.
- Michael.
On 16/07/2018, 12:10, Chris Hegarty wrote:
This is a review request for a small doc-only change to fix a
"bad" use of angle brackets ( for a parameterized type ) as
the target of an @link [*]. The simplest solution is to just
replace the link with @code, since the b
This is a review request for a small doc-only change to fix a
"bad" use of angle brackets ( for a parameterized type ) as
the target of an @link [*]. The simplest solution is to just
replace the link with @code, since the built javadoc contains
the appropriate links in the method declaration.
di
Andrew,
I filed the following issue to track this:
https://bugs.openjdk.java.net/browse/JDK-8207335
Once you produce an updated patch, I can review and
sponsor this for you.
-Chris.
On 12/07/18 08:21, Andrew Luo wrote:
Thanks, I can refactor it. I’m not as familiar with the OpenJDK
archite
On 12/07/2018 08:21, Andrew Luo wrote:
Thanks, I can refactor it. I’m not as familiar with the OpenJDK
architecture – should I just duplicate the function into libnio or is
there some common utility library that I should move it into? Also,
let me know what in net_util_* needs cleanup. The
