On 17/07/2018 07:33, Andrew Luo wrote:
Great, thanks.

By the way, I do see other places where we use NET_* functions in libnio, but 
if you prefer that I duplicate that code instead,
It's okay for the code in libnio/ch to use the NET_* functions. The issue is the changes to libnio/fs which is the file system code as that should have no dependences on functions exported by libnet. I think it would be better to drop the changes to the fs code in this patch. As we've been discussing, there are dozens of other areas that will work to allow fork/exec work reliably in native code, I think the networking and channels area is just the first step.

-Alan

Reply via email to