Re: RFR: 8205342: windows : potential memleaks in getAdapter(s) in NetworkInterface_winXP.c

Hi Matthias, On Fri, Jun 22, 2018 at 3:08 PM, Baesken, Matthias wrote: > Hello Alan, Thomas , I adjusted the line lengths and created a new webrev > : > > > > http://cr.openjdk.java.net/~mbaesken/webrevs/8205342.1/ > > > > I considered replacing the 100 for error_msg_buf size by a define

Re: RFR: 8205342: windows : potential memleaks in getAdapter(s) in NetworkInterface_winXP.c

Hello Matthias! Thanks for the fix! On 6/22/18 6:08 AM, Baesken, Matthias wrote: Hello Alan, Thomas , I adjusted the line lengths and created a new webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8205342.1/ I considered

RE: RFR: 8205342: windows : potential memleaks in getAdapter(s) in NetworkInterface_winXP.c

Hello Alan, Thomas , I adjusted the line lengths and created a new webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8205342.1/ I considered replacing the 100 for error_msg_buf size by a define (or maybe const int?) , should I do so ? Best regards, Matthias From: Alan Bateman