Hello Alan, Thomas , I adjusted the line lengths and created a new webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8205342.1/ I considered replacing the 100 for error_msg_buf size by a define (or maybe const int?) , should I do so ? Best regards, Matthias From: Alan Bateman [mailto:alan.bate...@oracle.com] Sent: Mittwoch, 20. Juni 2018 10:45 To: Baesken, Matthias <matthias.baes...@sap.com>; net-dev@openjdk.java.net Subject: Re: RFR: 8205342: windows : potential memleaks in getAdapter(s) in NetworkInterface_winXP.c On 20/06/2018 09:07, Baesken, Matthias wrote: Hello . Please review this small fix that fixes potential memory leaks in getAdapter(s) in NetworkInterface_winXP.c and simplifies the coding a bit too . Currently when generating error messages , some memory is malloc-ed for the error messages , but not always freed . Bug: https://bugs.openjdk.java.net/browse/JDK-8205342 webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8205342/<http://cr.openjdk.java.net/%7Embaesken/webrevs/8205342/> Can you fix the line lengths to make it consistent with original code? That will make it easier to look at side-by-side diffs. -Alan
