Re: Ping: RFR (M): 8167481: cleanup of headers and includes for native libnet

2016-10-18 Thread Chris Hegarty
Christoph, > On 17 Oct 2016, at 09:40, Langer, Christoph wrote: > … > Hi, > > as I already mentioned, here is another proposal for cleanup in libnet: > https://bugs.openjdk.java.net/browse/JDK-8167481 > http://cr.openjdk.java.net/~clanger/webrevs/8167481.0/ Overall, this looks good. Specific c

Re: [9] RFR: 8166530: sun/net/www/protocol/https/HttpsClient/ProxyAuthTest.java fails intermittently

2016-10-18 Thread Chris Hegarty
> On 7 Oct 2016, at 21:33, Artem Smotrakov wrote: > > Hello, > > Please review the patch below for > sun/net/www/protocol/https/HttpsClient/ProxyAuthTest.java test. > > The test has been observed to fail intermittently, but the failure is not > reproducible standalone. The patch updates the

Re: AF_INET6 support

2016-10-18 Thread Chris Hegarty
On 13 Oct 2016, at 09:46, Langer, Christoph wrote: > > Hi Chris, > >>> I’ve got a question regarding AF_INET6. >>> >>> In jdk native code you’ll still find lots of code guarded by “#ifdef >>> AF_INET6”. >> I’m wondering if there are still supported build environments where AF_INET6 >> is not

RE: [8u-dev] Request for Review + Approval: Backport of 8163181: Further improvements for Unix NetworkInterface native implementation

2016-10-18 Thread Langer, Christoph
Thanks, Chris. So then I'm asking for approval now... Best regards Christoph > -Original Message- > From: Chris Hegarty [mailto:chris.hega...@oracle.com] > Sent: Dienstag, 18. Oktober 2016 12:53 > To: Langer, Christoph > Cc: jdk8u-...@openjdk.java.net; Mark Sheppard > ; net-dev@openjdk.

Re: [8u-dev] Request for Review + Approval: Backport of 8163181: Further improvements for Unix NetworkInterface native implementation

2016-10-18 Thread Chris Hegarty
> On 17 Oct 2016, at 09:38, Langer, Christoph wrote: > > Hi, > > please review (@Chris or Mark) and approve the following downpour. From my point of view, I’m ok with this. You still need 8u maintainer approval. > Bug: https://bugs.openjdk.java.net/browse/JDK-8163181 > Original Change: http