RE: Patch for adding SO_REUSEPORT socket option

Hi All, Here is the most recent version of the patch. http://cr.openjdk.java.net/~mcberg/jdk/6432031/webrev.05/ We already tested patch on Linux 3.4.110 kernel and 3.18 kernel with regression tests from java.net and java.nio, and a simple program for reuseport. We also tested the same thing on

[PING] Re: Unexpected BindException in Endpoint.publish

Hi all, Please review this issue and patch. Thanks, Yuji 2015-10-29 3:22 GMT+09:00 KUBOTA Yuji : > Hi all, > > I'm at the HackerGarten @ JavaOne15, and write a patch for OpenJDK > community. This's second times from JavaOne14. :) > > We find an unexpected exception in JAX-WS, so I write a patch

Re: Request for review: 8144093: JEP 244/8051498 - TLS Application-Layer Protocol Negotiation Extension

Looks fine to me. Thanks for the update. Xuelei On 12/1/2015 7:08 AM, Vincent Ryan wrote: > Thanks for your review. Comments in-line. > >> On 30 Nov 2015, at 06:30, Xuelei Fan wrote: >> >> Looks fine to me. Just a few minor comments. >> >> ServerHandshaker.java >> = >> The

Re: Request for review: 8144093: JEP 244/8051498 - TLS Application-Layer Protocol Negotiation Extension

On 11/29/2015 4:08 PM, Vincent Ryan wrote: > Following on from Brad’s recent email, here is the full webrev of the > API and the implementation classes for ALPN: > http://cr.openjdk.java.net/~vinnie/8144093/webrev.00/ > > In adds the implementation classes (sun/security/ssl) to the public API >

Re: Request for review: 8144093: JEP 244/8051498 - TLS Application-Layer Protocol Negotiation Extension

Thanks for the review. I’ve incorporated your comments and Xuelei’s comments in a revised webrev: http://cr.openjdk.java.net/~vinnie/8144093/webrev.01/ > On 30 Nov 2015, at 21:10, Sean Mullan wrote: > > SSLParameters.java > > 649

Re: Request for review: 8144093: JEP 244/8051498 - TLS Application-Layer Protocol Negotiation Extension

Thanks for your review. Comments in-line. > On 30 Nov 2015, at 06:30, Xuelei Fan wrote: > > Looks fine to me. Just a few minor comments. > > ServerHandshaker.java > = > There is a typo of the first line. > - /* Copyright (c) 1996, 2015, ... > + /* > + * Copyright (c) 1996,

Re: Request for review: 8144093: JEP 244/8051498 - TLS Application-Layer Protocol Negotiation Extension

SSLParameters.java 649 applicationProtocols = protocols.clone(); You should clone the parameters before checking if they are valid. Move this to line 642, and check the validity of the cloned array. Also, use a temporary variable for the clone, so as not to pollute the applicationProt