SSLParameters.java 649 applicationProtocols = protocols.clone();
You should clone the parameters before checking if they are valid. Move this to line 642, and check the validity of the cloned array. Also, use a temporary variable for the clone, so as not to pollute the applicationProtocols field until you confirm the values are valid, and then assign it to applicationProtocols.
ExtensionType.java 47 new ArrayList<ExtensionType>(15); nit - you can use diamond operator above --Sean On 11/29/2015 07:08 PM, Vincent Ryan wrote:
Hello, Following on from Brad’s recent email, here is the full webrev of the API and the implementation classes for ALPN: http://cr.openjdk.java.net/~vinnie/8144093/webrev.00/ In adds the implementation classes (sun/security/ssl) to the public API classes (javax/net/ssl) which have already been agreed. Some basic tests (test/javax/net/ssl) are also included. Please send any code review comments by close-of-business on Tuesday 1 December. Thanks.