Re: RFR: 8087112: HTTP API and HTTP/1.1 implementation

2015-09-27 Thread Simone Bordet
Hi, On Fri, Aug 28, 2015 at 10:50 PM, Michael McMahon wrote: > Hi, > > I'm looking for reviewers for the http client implementation. > This is just the common API layer and the http/1.1 implementation. > > The webrev is at http://cr.openjdk.java.net/~michaelm/8087112/01/ It appears that none of

Re: RFR: 8087112: HTTP API and HTTP/1.1 implementation

2015-09-27 Thread Anthony Vanelverdinghe
Hi Michael I forgot to mention that, in Utils.java [1], the exception should also be thrown in case token is the empty string. And while I'm nitpicking anyway: here 's an alternative implementation which extracts the comparison logic in a separate method: static void validateToken(String tok