Hi,

On Fri, Aug 28, 2015 at 10:50 PM, Michael McMahon
<michael.x.mcma...@oracle.com> wrote:
> Hi,
>
> I'm looking for reviewers for the http client implementation.
> This is just the common API layer and the http/1.1 implementation.
>
> The webrev is at http://cr.openjdk.java.net/~michaelm/8087112/01/

It appears that none of my concerns expressed in this message:
http://mail.openjdk.java.net/pipermail/net-dev/2015-July/009048.html
have been addressed.
Am I looking at the right link ?

In particular:

A) lack of backpressure,
B) missing "request complete" event
C) missing timeouts (CompletableFuture.get(time) is obviously not the
right semantic)

are blockers for me.

The other points in my previous message are less blockers, but I would
still ask to consider them.

Thanks !

-- 
Simone Bordet
http://bordet.blogspot.com
---
Finally, no matter how good the architecture and design are,
to deliver bug-free software with optimal performance and reliability,
the implementation technique must be flawless.   Victoria Livschitz

Reply via email to