Hi Michael
Please review the code change at
http://cr.openjdk.java.net/~weijun/8055901/webrev.00/
With this change, the policy tool can generate a file like
grant {
permission jdk.net.NetworkPermission "setOption.SO_FLOW_SLA";
};
Please confirm the grammar is correct.
BTW, I also add som
Hi Michael, Chris and others
We’re working on moving our internal security tests to open idk
repo(Include refactoring effort). Could you please help to review these
tests?
Thanks,
Amanda
On 7/28/14 5:25 PM, Amanda Jiang wrote:
Hi All,
Could you please review 1 new test to be added for Sock
On 25/08/14 14:06, Chris Hegarty wrote:
Michael,
This looks mainly ok to me. It is nice to be adding to the common test
infrastructure, where possible. Just a few minor comments...
1) Do the tests what use this also need to ensure that the classfile is
compiled? We had trouble in the past
Michael,
The source changes look fine to me, but I know you are waiting on
another dependent bug to be able to update the test.
-Chris.
On 25/08/14 11:47, Michael McMahon wrote:
Thanks for looking at it. I need to get this one reviewed first
though, to re-organise one of the test support cla
Michael,
This looks mainly ok to me. It is nice to be adding to the common test
infrastructure, where possible. Just a few minor comments...
1) Do the tests what use this also need to ensure that the classfile is
compiled? We had trouble in the past when running concurrently.
@build jd
Thanks for looking at it. I need to get this one reviewed first
though, to re-organise one of the test support classes it uses
https://bugs.openjdk.java.net/browse/JDK-8055747
Michael
On 25/08/14 03:09, Xuelei Fan wrote:
Looks fine to me. Thanks for the update.
Xuelei
On 8/20/2014 9:02 PM,
On 22/08/14 18:08, Seán Coffey wrote:
Not sure how the SocksProxy.java change occurred. I'll fix that up
before pushing. Thanks for catching.
Good point about the NetworkPermission changes for policytool - I
don't see it in jdk 9 either (I see NetPermission being catered for)
jdk/src/jdk.runt
