Re: RFR 8046588: test for SO_FLOW_SLA availability does not check for EACCESS

2014-06-13 Thread Alan Bateman
On 13/06/2014 12:15, Michael McMahon wrote: To be honest, the test doesn't/(can't easily) check if a flow has been created. So, in practice a success return code doesn't prove that everything is working. Exercising the code at least is a basic smoke test. If we add a new exception then maybe w

Re: RFR 8046588: test for SO_FLOW_SLA availability does not check for EACCESS

2014-06-13 Thread Michael McMahon
On 13/06/14 12:10, Alan Bateman wrote: On 13/06/2014 11:49, Michael McMahon wrote: Okay. I can see the reasoning why supportedOptions should refer to the platform rather than the process/instance running. We could consider adding a sub-class of IOException for permission related failures, but

Re: RFR 8046588: test for SO_FLOW_SLA availability does not check for EACCESS

2014-06-13 Thread Alan Bateman
On 13/06/2014 11:49, Michael McMahon wrote: Okay. I can see the reasoning why supportedOptions should refer to the platform rather than the process/instance running. We could consider adding a sub-class of IOException for permission related failures, but I'm not proposing to do that here. For

Re: RFR 8046588: test for SO_FLOW_SLA availability does not check for EACCESS

2014-06-13 Thread Michael McMahon
On 13/06/14 10:08, Chris Hegarty wrote: On 12/06/14 21:04, Michael McMahon wrote: On 12/06/14 20:35, Alan Bateman wrote: On 12/06/2014 20:15, Michael McMahon wrote: It would be possible to change the error back, but what about supportedOptions() - what should that return? It doesn't seem ri

Re: RFR 8046588: test for SO_FLOW_SLA availability does not check for EACCESS

2014-06-13 Thread Chris Hegarty
On 12/06/14 21:04, Michael McMahon wrote: On 12/06/14 20:35, Alan Bateman wrote: On 12/06/2014 20:15, Michael McMahon wrote: It would be possible to change the error back, but what about supportedOptions() - what should that return? It doesn't seem right that it would include an option that