On 13/06/2014 12:15, Michael McMahon wrote:
To be honest, the test doesn't/(can't easily) check if a flow has been
created. So, in practice
a success return code doesn't prove that everything is working.
Exercising the code at least
is a basic smoke test. If we add a new exception then maybe we can
revisit, but I wanted
to get this change in ahead of the refactoring for modularity, becuase
this change
is needed for 8u20 and I don't want to hold that up and the
refactoring work will take some
time to review (it's a bit more complicated than expected).
At right, this is just exercising the code as it's not possible to real
test it with a test like this. In that case, the updated webrev looks
okay to me.
-Alan
