Re: RFR [9] 8035897 : FD_SETSIZE should be set on macosx

2014-02-28 Thread Christos Zoulas
On Feb 28, 5:41pm, chris.hega...@oracle.com (Chris Hegarty) wrote: -- Subject: Re: RFR [9] 8035897 : FD_SETSIZE should be set on macosx | We are using select on OS X, only, because of a bug in poll, see | https://bugs.openjdk.java.net/browse/JDK-7131399 | | Michael ran into this in the origina

RFR [9] 8035868: Check for JNI pending exception in windows/native/sun/net/spi/DefaultProxySelector.c

2014-02-28 Thread Chris Hegarty
Some more trivial checking in the Windows native code for JNI pending exceptions. http://cr.openjdk.java.net/~chegar/8035868/webrev.00/webrev/ -Chris.

Re: RFR [9] 8035897 : FD_SETSIZE should be set on macosx

2014-02-28 Thread Chris Hegarty
On 28 Feb 2014, at 17:28, chris...@zoulas.com wrote: > On Feb 28, 3:55pm, michael.x.mcma...@oracle.com (Michael McMahon) wrote: > -- Subject: Re: RFR [9] 8035897 : FD_SETSIZE should be set on macosx > > | On 28/02/14 14:40, Chris Hegarty wrote: > | > [ Volker: there are some trivial AIX changes

Re: RFR [9] 8035897 : FD_SETSIZE should be set on macosx

2014-02-28 Thread Christos Zoulas
On Feb 28, 3:55pm, michael.x.mcma...@oracle.com (Michael McMahon) wrote: -- Subject: Re: RFR [9] 8035897 : FD_SETSIZE should be set on macosx | On 28/02/14 14:40, Chris Hegarty wrote: | > [ Volker: there are some trivial AIX changes here, maybe you could | > verify them? ] | > | > JDK-8021820 ad

Re: RFR[9](M): 8035949 : Remove unused macro USE_SELECT and clean up Unix version of net_util_md.{c,h}

2014-02-28 Thread Volker Simonis
Hi Alan, Chris, thanks for the review. I've just pushed the change with the additions proposed by you (I also removed the similar blocks/comments in PlainSocketImpl.c). Regards, Volker On Fri, Feb 28, 2014 at 3:14 PM, Alan Bateman wrote: > On 28/02/2014 14:08, Chris Hegarty wrote: >> >> Volker

Re: RFR [9] 8035897 : FD_SETSIZE should be set on macosx

2014-02-28 Thread Chris Hegarty
Thanks for looking at this Michael, comments inline... On 28/02/14 15:55, Michael McMahon wrote: ... I agree option 2 sounds better since adding (say) 4k * sizeof(fd_set) to the stack is quite significant given that it would rarely be required. Agreed. On the change itself I noticed one pat

Re: RFR [9] 8035897 : FD_SETSIZE should be set on macosx

2014-02-28 Thread Michael McMahon
On 28/02/14 14:40, Chris Hegarty wrote: [ Volker: there are some trivial AIX changes here, maybe you could verify them? ] JDK-8021820 adds -D_DARWIN_UNLIMITED_SELECT to the build, but the fd_set struct is still limited to 1024. Snippet from man select(2): "Although the provision of getdt

RFR [9] 8035897 : FD_SETSIZE should be set on macosx

2014-02-28 Thread Chris Hegarty
[ Volker: there are some trivial AIX changes here, maybe you could verify them? ] JDK-8021820 adds -D_DARWIN_UNLIMITED_SELECT to the build, but the fd_set struct is still limited to 1024. Snippet from man select(2): "Although the provision of getdtablesize(2) was intended to allow user p

Re: RFR[9](M): 8035949 : Remove unused macro USE_SELECT and clean up Unix version of net_util_md.{c,h}

2014-02-28 Thread Alan Bateman
On 28/02/2014 14:08, Chris Hegarty wrote: Volker, The changes look fine to me, and in line with what I was thinking too. Quite trivially you can remove the block '{' from net_util_md.c Line 1637 and 1650. Also, the function comment says "Wrapper for select/poll ..." ( can remove 'select' ).

Re: RFR[9](M): 8035949 : Remove unused macro USE_SELECT and clean up Unix version of net_util_md.{c,h}

2014-02-28 Thread Chris Hegarty
Volker, The changes look fine to me, and in line with what I was thinking too. Quite trivially you can remove the block '{' from net_util_md.c Line 1637 and 1650. Also, the function comment says "Wrapper for select/poll ..." ( can remove 'select' ). I ran your patch through our internal buil