Hi Alan, Chris,
thanks for the review. I've just pushed the change with the additions
proposed by you (I also removed the similar blocks/comments in
PlainSocketImpl.c).
Regards,
Volker
On Fri, Feb 28, 2014 at 3:14 PM, Alan Bateman <alan.bate...@oracle.com> wrote:
> On 28/02/2014 14:08, Chris Hegarty wrote:
>>
>> Volker,
>>
>> The changes look fine to me, and in line with what I was thinking too.
>> Quite trivially you can remove the block '{' from net_util_md.c Line 1637
>> and 1650. Also, the function comment says "Wrapper for select/poll ..." (
>> can remove 'select' ).
>>
> It looks okay to me too.
>
> AFAIK, USE_SELECT was a build time option a long time ago (when the JDK had
> the HPI). It's good to see this dead code go away now.
>
> -Alan.
