hg: jdk8/tl/jdk: 5 new changesets

2013-05-15 Thread valerie . peng
Changeset: 2ec31660cc0e Author:valeriep Date: 2013-05-07 14:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2ec31660cc0e 8010134: A finalizer in sun.security.pkcs11.wrapper.PKCS11 perhaps should be protected Summary: Change the finalize method of PKCS11 class to be protect

Code Review Request: 7150552: network test hangs [macosx]

2013-05-15 Thread Kurchi Hazra
Hi, Two regression tests in jdk/test were hanging on Mac OS X intermittently. Although it is difficult to reproduce the problem, I suspect it is the use of the buggy httpserver test library (jdk/test/sun/net/www/httptest) - we anyway want to move away from using it. I have re-written parts of

Re: Non-standard socket options?

2013-05-15 Thread Brian Call
I just asked Neil if that option was supported for ipv6 and he said that he doesn't think so... Likely once adoption of ipv6 reaches critical mass and enough people complain, it will be added. We can only hope... Please let me know if I can be of any more assistance. -Brian On May 11, 2013,

Re: Incorrect handling of HTTP/1.1 "Expect: 100-continue" in HttpURLConnection

2013-05-15 Thread Piotr Bzdyl
Thank you again for taking time to look at the issue. The proposed fix will eliminate the surprise we encountered as there will be no delay when Expect header and no streaming is used. Best regards, Piotr On Wed, May 15, 2013 at 6:33 PM, Michael McMahon < michael.x.mcma...@oracle.com> wrote: >

Re: Incorrect handling of HTTP/1.1 "Expect: 100-continue" in HttpURLConnection

2013-05-15 Thread Alan Bateman
On 15/05/2013 18:09, Chris Hegarty wrote: The change looks fine to me. -Chris On 15 May 2013, at 17:33, Michael McMahon mailto:michael.x.mcma...@oracle.com>> wrote: This is the webrev for the bug http://cr.openjdk.java.net/~michaelm/8012625/webrev.1/ Thanks Michael The fix looks okay to

hg: jdk8/tl/langtools: 8006879: Detection of windows in sjavac fails.

2013-05-15 Thread jonathan . gibbons
Changeset: 445b8b5ae9f4 Author:jjg Date: 2013-05-15 10:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/445b8b5ae9f4 8006879: Detection of windows in sjavac fails. Reviewed-by: jjg Contributed-by: erik.joels...@oracle.com ! src/share/classes/com/sun/tools/sjavac/serve

Re: Incorrect handling of HTTP/1.1 "Expect: 100-continue" in HttpURLConnection

2013-05-15 Thread Chris Hegarty
The change looks fine to me. -Chris On 15 May 2013, at 17:33, Michael McMahon wrote: > This is the webrev for the bug > > http://cr.openjdk.java.net/~michaelm/8012625/webrev.1/ > > Thanks > Michael > > On 15/05/13 17:03, Michael McMahon wrote: >> Piotr, >> >> We took a look at this issue ag

hg: jdk8/tl/jdk: 8014677: Correct docs warning for Objects.requireNonNull(T, Supplier)

2013-05-15 Thread joe . darcy
Changeset: bad8f5237f10 Author:darcy Date: 2013-05-15 09:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bad8f5237f10 8014677: Correct docs warning for Objects.requireNonNull(T, Supplier) Reviewed-by: alanb ! src/share/classes/java/util/Objects.java

Re: Incorrect handling of HTTP/1.1 "Expect: 100-continue" in HttpURLConnection

2013-05-15 Thread Michael McMahon
This is the webrev for the bug http://cr.openjdk.java.net/~michaelm/8012625/webrev.1/ Thanks Michael On 15/05/13 17:03, Michael McMahon wrote: Piotr, We took a look at this issue again, and while it is still the case that to get Expect: Continue to work properly, you need to enable one of th

Re: Incorrect handling of HTTP/1.1 "Expect: 100-continue" in HttpURLConnection

2013-05-15 Thread Michael McMahon
Piotr, We took a look at this issue again, and while it is still the case that to get Expect: Continue to work properly, you need to enable one of the streaming modes. However, prior to jdk7 there was partial support for this mechanism, where it obeyed the protocol at least when you set the Ex

hg: jdk8/tl/jdk: 8013730: JSR 310 DateTime API Updates III

2013-05-15 Thread xueming . shen
Changeset: ef04044f77d2 Author:sherman Date: 2013-05-15 07:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ef04044f77d2 8013730: JSR 310 DateTime API Updates III Summary: Integration of JSR310 Date/Time API update III Reviewed-by: naoto Contributed-by: scolebou...@joda.org,

hg: jdk8/tl/langtools: 3 new changesets

2013-05-15 Thread maurizio . cimadamore
Changeset: 05ec778794d0 Author:mcimadamore Date: 2013-05-15 14:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/05ec778794d0 8012003: Method diagnostics resolution need to be simplified in some cases Summary: Unfold method resolution diagnostics when they mention error

Re: RFR JDK7188517

2013-05-15 Thread Chris Hegarty
On 15/05/2013 13:02, Chris Hegarty wrote: I believe the reviews on the open list are complete. The CCC has been accepted, nut it needs to be make final, then the CCC committee need to vote again. I did send mail to you about making it final ( one step process ), but you may not have seen it

[OFFLIST] Re: RFR JDK7188517

2013-05-15 Thread Chris Hegarty
[OFFLIST] I believe the reviews on the open list are complete. The CCC has been accepted, nut it needs to be make final, then the CCC committee need to vote again. I did send mail to you about making it final ( one step process ), but you may not have seen it. -Chris. On 15/05/2013 12:54,

Re: Code review: 8010464: Evolve java networking same origin policy

2013-05-15 Thread Alan Bateman
On 15/05/2013 12:46, Michael McMahon wrote: updated here: http://cr.openjdk.java.net/~michaelm/8010464/webrev.3/ Michael. This looks much better. In HttpURLConnection then odd formatting in the declaration of followRedirect0 (which probably needs a better name, maybe implFollowRedirect?)

Re: RFR JDK7188517

2013-05-15 Thread John Zavgren
Greetings: Can I get a show of hands on this RFR (http://cr.openjdk.java.net/~jzavgren/7188517/webrev.04/)? It's CCC request has been accepted and I'd like to wrap it up ASAP. Thanks! John Zavgren On 05/09/2013 02:22 PM, John Zavgren wrote: Greetings: I made a mistake in my last RFR posting.

Re: Code review: 8010464: Evolve java networking same origin policy

2013-05-15 Thread Michael McMahon
On 15/05/13 12:12, Michael McMahon wrote: On 15/05/13 12:02, Alan Bateman wrote: On 15/05/2013 11:34, Michael McMahon wrote: ... I'll post one more webrev, and push it soon afterwards as I'd like to make the code freeze today. Okay. updated here: http://cr.openjdk.java.net/~michaelm

Re: Code review: 8010464: Evolve java networking same origin policy

2013-05-15 Thread Michael McMahon
On 15/05/13 12:02, Alan Bateman wrote: On 15/05/2013 11:34, Michael McMahon wrote: : On MessageHeader then getHeaderNamesInList could use java.util.StringJoiner to avoid rolling your own. I can see the benefit of using StringJoiner (and a lambda) if I am starting off from a Collection and

Re: Code review: 8010464: Evolve java networking same origin policy

2013-05-15 Thread Alan Bateman
On 15/05/2013 11:34, Michael McMahon wrote: : On MessageHeader then getHeaderNamesInList could use java.util.StringJoiner to avoid rolling your own. I can see the benefit of using StringJoiner (and a lambda) if I am starting off from a Collection and this is something that only struck me w

Re: Code review: 8010464: Evolve java networking same origin policy

2013-05-15 Thread Michael McMahon
On 15/05/13 11:04, Alan Bateman wrote: On 14/05/2013 12:54, Michael McMahon wrote: I have updated the webrev for this at: http://cr.openjdk.java.net/~michaelm/8010464/webrev.2/ I took a pass over the updated webrev and it mostly looks good to me. In HttpURLConnection then I wonder if it woul

Re: Code review: 8010464: Evolve java networking same origin policy

2013-05-15 Thread Alan Bateman
On 14/05/2013 12:54, Michael McMahon wrote: I have updated the webrev for this at: http://cr.openjdk.java.net/~michaelm/8010464/webrev.2/ I took a pass over the updated webrev and it mostly looks good to me. In HttpURLConnection then I wonder if it would be better if getInputStream, getOutpu

Re: Code review: 8010464: Evolve java networking same origin policy

2013-05-15 Thread Michael McMahon
On 15/05/13 10:09, Chris Hegarty wrote: What you have in the latest version of this webrev look fine to me. Thanks Chris! Michael -Chris. On 14/05/2013 12:54, Michael McMahon wrote: I have updated the webrev for this at: http://cr.openjdk.java.net/~michaelm/8010464/webrev.2/ Thanks Mich

Re: Code review: 8010464: Evolve java networking same origin policy

2013-05-15 Thread Chris Hegarty
What you have in the latest version of this webrev look fine to me. -Chris. On 14/05/2013 12:54, Michael McMahon wrote: I have updated the webrev for this at: http://cr.openjdk.java.net/~michaelm/8010464/webrev.2/ Thanks Michael.

hg: jdk8/tl/langtools: 8004133: Provide javax.lang.model.* implementation backed by core reflection

2013-05-15 Thread joe . darcy
Changeset: bcd927639039 Author:darcy Date: 2013-05-15 00:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bcd927639039 8004133: Provide javax.lang.model.* implementation backed by core reflection Summary: Joint work by darcy and jfranck to provide sample code for JEP 1