hg: jdk7/tl/langtools: 6968497: localized text appears in raw diagnostic

2010-07-12 Thread jonathan . gibbons
Changeset: 064468702a8d Author:jjg Date: 2010-07-12 16:37 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/064468702a8d 6968497: localized text appears in raw diagnostic Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/comp/Check.java ! test/tools/javac/generic

hg: jdk7/tl/jdk: 2 new changesets

2010-07-12 Thread daniel . daugherty
Changeset: ddf825161d2d Author:dcubed Date: 2010-07-12 14:19 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ddf825161d2d 6968401: 3/3 disable tests added by 6942989 until 6964018 is fixed Summary: Disable AnonLoggerWeakRefLeak.sh and LoggerWeakRefLeak.sh Reviewed-by: ohair !

hg: jdk7/tl/jdk: 6921472: RFE: java launcher code needs clean up

2010-07-12 Thread kumar . x . srinivasan
Changeset: d3fa95d0710c Author:ksrini Date: 2010-07-09 11:04 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d3fa95d0710c 6921472: RFE: java launcher code needs clean up Summary: This changeset also contains fixes for 6405284, 6753938 and 6922500 Reviewed-by: darcy ! src/shar

Re: 6964714, Please review the fix (XS), round 3

2010-07-12 Thread Chris Hegarty
Dmitry, looks good. -Chris. Dmitry Samersoff wrote: On 2010-07-12 22:30, Alan Bateman wrote: Dmitry Samersoff wrote: Alan, Thank you for the comments. Fixed. http://cr.openjdk.java.net/~dsamersoff/6964714/webrev.04/ -Dmitry The copyright date on the new test says 2008 :-) Copy-paste fr

Re: 6964714, Please review the fix (XS), round 3

2010-07-12 Thread Dmitry Samersoff
On 2010-07-12 22:30, Alan Bateman wrote: Dmitry Samersoff wrote: Alan, Thank you for the comments. Fixed. http://cr.openjdk.java.net/~dsamersoff/6964714/webrev.04/ -Dmitry The copyright date on the new test says 2008 :-) Copy-paste from a neighbor ;) Fixed? http://cr.openjdk.java.net/~d

Re: 6964714, Please review the fix (XS), round 3

2010-07-12 Thread Alan Bateman
Dmitry Samersoff wrote: Alan, Thank you for the comments. Fixed. http://cr.openjdk.java.net/~dsamersoff/6964714/webrev.04/ -Dmitry The copyright date on the new test says 2008 :-) Otherwise looks good to me. -Alan.

Re: 6964714, Please review the fix (XS), round 3

2010-07-12 Thread Dmitry Samersoff
Alan, Thank you for the comments. Fixed. http://cr.openjdk.java.net/~dsamersoff/6964714/webrev.04/ -Dmitry On 2010-07-12 12:00, Alan Bateman wrote: Dmitry Samersoff wrote: Chris, Please review my changes. see: http://cr.openjdk.java.net/~dsamersoff/6964714/webrev.03/ -Dmitry The fix t

hg: jdk7/tl/jdk: 3 new changesets

2010-07-12 Thread chris . hegarty
Changeset: a7f8f269f741 Author:chegar Date: 2010-07-12 18:13 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a7f8f269f741 6967937: Scope id no longer being set after 6931566 Reviewed-by: alanb, dsamersoff ! src/solaris/native/java/net/NetworkInterface.c ! test/java/net/Inet6A

Re: Code Review 6967937: Scope id no longer being set after 6931566

2010-07-12 Thread Alan Bateman
Chris Hegarty wrote: : Updated Webrev: http://cr.openjdk.java.net/~chegar/6967937/webrev.01/webrev/ The updated webrev looks good to me. -Alan.

Re: Code Review 6967937: Scope id no longer being set after 6931566

2010-07-12 Thread Chris Hegarty
On 07/12/10 12:32, Alan Bateman wrote: Chris Hegarty wrote: Alan, Dmitry, Michael, CR: Scope id no longer being set after 6931566 CR 6931566 accidentally removes the setting of the scope id for IPv6 addresses before adding them to the interface list. This was missed during code review as there

Re: Code Review 6967937: Scope id no longer being set after 6931566

2010-07-12 Thread Dmitry Samersoff
On 2010-07-12 13:54, Chris Hegarty wrote: Alan, Dmitry, Michael, CR: Scope id no longer being set after 6931566 Looks good for me. Thank you for fixing it. -Dmitry CR 6931566 accidentally removes the setting of the scope id for IPv6 addresses before adding them to the interface list. This

Re: Code Review 6967937: Scope id no longer being set after 6931566

2010-07-12 Thread Alan Bateman
Chris Hegarty wrote: Alan, Dmitry, Michael, CR: Scope id no longer being set after 6931566 CR 6931566 accidentally removes the setting of the scope id for IPv6 addresses before adding them to the interface list. This was missed during code review as there was a lot of refactoring to clean up

Code Review 6967937: Scope id no longer being set after 6931566

2010-07-12 Thread Chris Hegarty
Alan, Dmitry, Michael, CR: Scope id no longer being set after 6931566 CR 6931566 accidentally removes the setting of the scope id for IPv6 addresses before adding them to the interface list. This was missed during code review as there was a lot of refactoring to clean up the code. The solutio

Re: 6964714, Please review the fix (XS), round 3

2010-07-12 Thread Alan Bateman
Dmitry Samersoff wrote: Chris, Please review my changes. see: http://cr.openjdk.java.net/~dsamersoff/6964714/webrev.03/ -Dmitry The fix to NetworkInterface.c looks good to me. I notice you've got the Sun copyright header in the test so that should be fixed. Also I agree with Chris's comme