Re: Request for Review 6882594

2009-09-17 Thread Alan Bateman
Christopher Hegarty -Sun Microsystems Ireland wrote: Max (Weijun) Wang wrote: HttpURLConnection.java: I think "if (authScheme.equals(BASIC))" can be written as "authScheme == BASIC", and possibly you can use switch/case in several places Thanks Max, these changes certainly make the code

hg: jdk7/tl/jdk: 30 new changesets

2009-09-17 Thread tim . bell
Changeset: 559fb14d0ae9 Author:anthony Date: 2009-08-27 16:42 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/559fb14d0ae9 6780496: Javaw process taking up 80-90 percent of CPU time! Summary: The transparency effects get enabled on showing, and disabled on hiding a window Rev

hg: jdk7/tl/hotspot: 31 new changesets

2009-09-17 Thread tim . bell
Changeset: a05ea7791ee3 Author:trims Date: 2009-08-21 20:38 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/a05ea7791ee3 6873236: Fork HS16 to HS17 - renumber Major and build numbers of JVM Summary: Update the Major and build numbers for HS17 fork Reviewed-by: jcoomes ! m

hg: jdk7/tl: 2 new changesets

2009-09-17 Thread tim . bell
Changeset: 4079d923a501 Author:peterz Date: 2009-08-31 14:10 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/rev/4079d923a501 6844267: Nimbus generator depends on JIBX Summary: Nimbus generator now uses JAXB instead of JIBX Reviewed-by: jasper ! README-builds.html Changeset: 0d7e03b

Re: Request for Review 6882594

2009-09-17 Thread Christopher Hegarty -Sun Microsystems Ireland
Max (Weijun) Wang wrote: HttpURLConnection.java: I think "if (authScheme.equals(BASIC))" can be written as "authScheme == BASIC", and possibly you can use switch/case in several places Thanks Max, these changes certainly make the code more readable. Updated webrev can be found at: http:

Re: Request for Review 6882594

2009-09-17 Thread Max (Weijun) Wang
HttpURLConnection.java: I think "if (authScheme.equals(BASIC))" can be written as "authScheme == BASIC", and possibly you can use switch/case in several places Thanks Max On Sep 17, 2009, at 6:55 PM, Christopher Hegarty -Sun Microsystems Ireland wrote: I removed the use of char (sch

Re: Request for Review 6882594

2009-09-17 Thread Christopher Hegarty -Sun Microsystems Ireland
I removed the use of char (schemeId) completed and replaced it the the new AuthScheme enum. This makes the code much cleaner. Thanks Max and Alan for this suggestion. Updated webrev can be found at: http://cr.openjdk.java.net/~chegar/6882594/webrev.1/webrev/ Thanks, -Chris. Christopher Hega