For vi-like binding users, use Esc key to abort commands

2017-02-25 Thread Walter Alejandro Iglesias
Hello, I'm not quite skilled in C but I think I figured out how to add a boolean variable 'esc_key_aborts' to set ESC key as an alternative to the default emacs-like Ctrl-G to abort commands. I guess vi-like users will appreciate this feature. --- mutt-1.7.2/mutt.h Mon Dec 5 00:46:59 2016 ++

Re: For vi-like binding users, use Esc key to abort commands

2017-02-25 Thread Walter Alejandro Iglesias
Hello Kevin! > Hi Walter, > > It looks like you were able to subscribe to the mailing list finally. > Did you figure out what the problem was? It was just the majordomo server is *very* slow. Login to change my preferences took me a while too. > I'll take a closer look at the patch, but my con

Re: For vi-like binding users, use Esc key to abort commands

2017-02-25 Thread Walter Alejandro Iglesias
Hi again, I'm getting old and stupid. In my first message I'd pasted mutt.h two times and forgot to include keymap.c. Anyway, I found a first problem. Compiled with my patches I get this error at startup: Invalid value for option send_charset: "us-ascii:utf-8" It complains when I set any b

Last version

2017-02-25 Thread Walter Alejandro Iglesias
Last version (I'd made keymap.c diff in the opposite way). The *good news* is the send_charset error wasn't due to my patches but some config option I'm missing. Here you are: --- mutt-1.7.2/mutt.h Mon Dec 5 00:46:59 2016 +++ mutt-1.7.2-modified/mutt.h Sat Feb 25 23:12:19 2017 @@ -340,6 +3

Re: Last version

2017-02-26 Thread Walter Alejandro Iglesias
Hello Andras, > How does this interact with the large number of commands that by default > are bound to Esc ? Your question is already answered in the thread and in the diff itself (the text I added to init.h is inserted to muttrc(5) when you compile.) Reasoning: While you *have* the option to

Re: Last version

2017-02-26 Thread Walter Alejandro Iglesias
> On Sun, Feb 26, 2017 at 05:59:09PM +0100, Walter Alejandro Iglesias wrote: > > The interesting question, based on what kevin@ suggested, is if there > > are other functionality affected besides edit line. Please, test the > > patches and let us know. > > I haven

A more agnostic functions.h

2017-02-27 Thread Walter Alejandro Iglesias
Let's see if we avoid confusion. :-) I've changed to NULL all esc prefixed bindings in functions.h getting a more agnostic defaults (personally, I'd remove all, but let's see if people is willing to accept the change first). Then I created a default.bindings.rc configuration file containing *all*

New proposal

2017-03-03 Thread Walter Alejandro Iglesias
I thought it twice. Modifying functions.h will be even more confusing. New proposal: 1. Same original patches except for init.h. The man page now will show: esc_key_aborts Type: boolean Default: no When set, ESC key is used instead Ctrl-G to abort commands. This

Re: New proposal

2017-03-03 Thread Walter Alejandro Iglesias
On Fri, Mar 03, 2017 at 01:50:46PM -0800, Will Yardley wrote: > On Fri, Mar 03, 2017 at 02:52:02PM +0100, guyzmo wrote: > > > > even though I think the idea of rebinding the abort key is likable, > > making it a binary choice between and is not the best way to > > go, it should be bindable to an

Re: For vi-like binding users, use Esc key to abort commands

2017-03-08 Thread Walter Alejandro Iglesias
Oswald Buddenhagen wrote: > i strongly suggest you take inspiration from how midnight commander ... Honestly, I don't see the point in overcomplicating the code to avoid the Meta-key issue. Would you write a command to check if Ctrl-Z is bound to any function and print an error message? My sol

BUG: km_error_key() isn't able to deal with Ctrl prefixed bindings

2017-04-20 Thread Walter Alejandro Iglesias
I found a bug. If you bind any Ctrl prefixed combination to help and press any unbound key, km_error_key() prints just "Key is not bound." For example, after defining this: :bind index \Ch help :bind index l noop If in the index you press 'l' you have the following message: Key is not bound

Make Mutt vi users friendly, new set of patches

2023-09-07 Thread Walter Alejandro Iglesias
Hello list, This is a new version of a set of patches and a proposal I posted to mutt-dev@ many years ago (2017): http://en.roquesor.com/Downloads/muttesckey.tar.gz It adds an option to change the hardcoded Ctrl-G to Esc as abort key, convenient for vi users. With the old set there was an inc

Compatibility with mailx aliases

2024-06-21 Thread Walter Alejandro Iglesias
Traditional mailx (bsd versions and GNU mailutils) needs this syntax for aliases: alias john"John Dou " With full addresses, since they contain spaces, you need to enclose them in quotes. Any unix user would tend to add those quotes since there are three fields there, not five. If you add

Re: Compatibility with mailx aliases

2024-06-22 Thread Walter Alejandro Iglesias
Hi Rene, On Sat, Jun 22, 2024 at 10:36:52AM +0200, Rene Kita wrote: > On Sat, Jun 22, 2024 at 07:13:16AM +0200, Walter Alejandro Iglesias wrote: > > Traditional mailx (bsd versions and GNU mailutils) needs this syntax for > > aliases: > > > > alias john&qu

Re: Compatibility with mailx aliases

2024-06-22 Thread Walter Alejandro Iglesias
Hi Alejandro, On Sat, Jun 22, 2024 at 11:02:28AM +0200, Alejandro Colomar wrote: > Hi Walter, > > On Sat, Jun 22, 2024 at 10:36:52AM GMT, Rene Kita wrote: > > On Sat, Jun 22, 2024 at 07:13:16AM +0200, Walter Alejandro Iglesias wrote: > > > Traditional mailx (bsd versions

Re: Compatibility with mailx aliases

2024-06-22 Thread Walter Alejandro Iglesias
On Sat, Jun 22, 2024 at 11:32:06AM +0200, Walter Alejandro Iglesias wrote: > Hi Alejandro, > > On Sat, Jun 22, 2024 at 11:02:28AM +0200, Alejandro Colomar wrote: > > Hi Walter, > > > > On Sat, Jun 22, 2024 at 10:36:52AM GMT, Rene Kita wrote: > > > On Sat, Jun

Re: Compatibility with mailx aliases

2024-06-22 Thread Walter Alejandro Iglesias
On Sat, Jun 22, 2024 at 11:36:47AM +0200, Walter Alejandro Iglesias wrote: > > > A lot of existing software requires quoting the name when it contains > > > '.'. What does BSD or GNU mailutils with those? Does it use single > > > quotes or what?

Re: Compatibility with mailx aliases

2024-06-22 Thread Walter Alejandro Iglesias
On Sun, Jun 23, 2024 at 06:29:45AM +0200, Rene Kita wrote: > On Sat, Jun 22, 2024 at 11:23:40AM +0200, Walter Alejandro Iglesias wrote: > > I was lazy, I didn't take a look at the code before sending this > > suggestion. Now I tested your patch and it works, but I don't

Re: Compatibility with mailx aliases

2024-06-23 Thread Walter Alejandro Iglesias
On Sun, Jun 23, 2024 at 03:43:50PM +0800, Kevin J. McCarthy wrote: > On Sun, Jun 23, 2024 at 08:44:44AM +0200, Rene Kita wrote: > >On Sun, Jun 23, 2024 at 01:53:21PM +0800, Kevin J. McCarthy wrote: > >> On Sun, Jun 23, 2024 at 06:29:45AM +0200, Rene Kita wrote: > >> > MUTT_TOKEN_QUOTE tells mutt to

Abort with Esc (PATCHES - 3rd ping)

2024-07-17 Thread Walter Alejandro Iglesias
Excuse my insistence, but I use vi-like bindings even in my shell, after using mutt for decades I still insult RMS every time I mistakenly press Esc to abort a command. :-) Could you give my patches *one* chance or at least let me know why they are ignored, please? https://en.roquesor.com/Down

Re: Abort with Esc (PATCHES - 3rd ping)

2024-07-17 Thread Walter Alejandro Iglesias
Hi Rene, First of all, thank you for being considerate of me. :-) On Wed, Jul 17, 2024 at 02:22:33PM +0200, Rene Kita wrote: > On Wed, Jul 17, 2024 at 12:59:48PM +0200, Walter Alejandro Iglesias wrote: > > Excuse my insistence, but I use vi-like bindings even in my shell, after >

Re: Abort with Esc (PATCHES - 3rd ping)

2024-07-17 Thread Walter Alejandro Iglesias
On Wed, Jul 17, 2024 at 04:31:08PM +0200, Rene Kita wrote: > On Wed, Jul 17, 2024 at 03:54:12PM +0200, Walter Alejandro Iglesias wrote: > > Besides, giving the user an option to choose any key binding to > > abort is difficult to accomplish for the way this special binding was &

Re: Abort with Esc (PATCHES - 3rd ping)

2024-07-18 Thread Walter Alejandro Iglesias
On Wed, Jul 17, 2024 at 04:31:08PM +0200, Rene Kita wrote: > On Wed, Jul 17, 2024 at 03:54:12PM +0200, Walter Alejandro Iglesias wrote: > > I think you're confusing (shell) cancel with abort. Ctrl-C is also > > there. > > No, I'm not confusing it. Ctrl-C came