[PATCH] Fix sidebar_sort_method usage in documentation

2020-05-15 Thread Remco Rijnders
From: Remco Rijnders --- init.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/init.h b/init.h index dc4832b6..6fd1ddc6 100644 --- a/init.h +++ b/init.h @@ -3396,7 +3396,7 @@ struct option_t MuttVars[] = { { "sidebar_sort_method", DT_SORT|DT_SORT_SIDEBAR, R_SIDEBAR,

[PATCH 3/3] Remove support for OpenSSL <0.9.5

2020-05-24 Thread Remco Rijnders
The current code provides a workaround for the absence of RAND_status in OpenSSL versions before 0.9.5. The comments in the code indicate these versions have to be supported, but as these versions are now more than 20 years old, this no longer applies. Removing this support simplifies the code and

[PATCH 1/3] Use LFSR113 PRNG for mutt's internal random needs

2020-05-24 Thread Remco Rijnders
s_error; mutt_message = mutt_nocurses_error; - SRAND (time (NULL)); umask (077); memset (Options, 0, sizeof (Options)); diff --git a/mutt_random.c b/mutt_random.c new file mode 100644 index ..ab0e6a84 --- /dev/null +++ b/mutt_random.c @@ -0,0 +1,64 @@ +/* + * Copyright (C) 2020 Remco Rijnd

[PATCH 2/3] Simplify mutt_generate_boundary to use new mutt_base64_random96 function

2020-05-24 Thread Remco Rijnders
--- sendlib.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/sendlib.c b/sendlib.c index f5389d8b..77c14e8f 100644 --- a/sendlib.c +++ b/sendlib.c @@ -516,13 +516,8 @@ int mutt_write_mime_body (BODY *a, FILE *f) void mutt_generate_boundary (PARAMETER **parm) { char

[PATCH 2/3] Change Message-ID generation to be more unique and leak less information

2020-05-24 Thread Remco Rijnders
A Message-ID should be globally unique. Currently mutt generates this ID based on the current date and time, followed by ".G", followed by a letter A to Z (A for the 1st and 27th email sent, Z for the 26th, etc.), followed by the pid of the active mutt process, followed by "@" and the configured fq

[PATCH 1/3] Change Message-ID generation to be more unique and leak less information

2020-05-24 Thread Remco Rijnders
A Message-ID should be globally unique. Currently mutt generates this ID based on the current date and time, followed by ".G", followed by a letter A to Z (A for the 1st and 27th email sent, Z for the 26th, etc.), followed by the pid of the active mutt process, followed by "@" and the configured fq

[PATCH 3/3] Change Message-ID generation to be more unique and leak less information

2020-05-24 Thread Remco Rijnders
A Message-ID should be globally unique. Currently mutt generates this ID based on the current date and time, followed by ".G", followed by a letter A to Z (A for the 1st and 27th email sent, Z for the 26th, etc.), followed by the pid of the active mutt process, followed by "@" and the configured fq

Re: [PATCH 1/3] Use LFSR113 PRNG for mutt's internal random needs

2020-05-24 Thread Remco Rijnders
Makefile.am | 3 ++- configure.ac | 1 - Please note that I am not comfortable enough with autotools to be certain if I did this the correct way (configure.ac) and also my change to the Makefile might be sub optimal, I am not sure. Cheers, Remco

Re: [PATCH 1/3] Use LFSR113 PRNG for mutt's internal random needs

2020-05-25 Thread Remco Rijnders
On Sun, May 24, 2020 at 06:49:03PM -0700, Kevin wrote in <20200525014903.ga1...@afu.lan>: On Sun, May 24, 2020 at 04:59:24PM -0400, Remco Rijnders wrote: By implementing the LFSR113 function by Pierre L'Ecuyer mutt gets a fast and high quality PRNG that, given the same seeds, results

Re: [PATCH 1/3] Use LFSR113 PRNG for mutt's internal random needs

2020-05-25 Thread Remco Rijnders
On Mon, May 25, 2020 at 08:02:54AM +0200, Petr wrote in <20200525060254.ga3...@album.bayer.uni.cx>: Software distributors are not happy seeing various software carrying its own cryptographic code. Could you please keep using the system-provided functions if available? Hi Petr, Thank you for yo

Re: [PATCH 1/3] Use LFSR113 PRNG for mutt's internal random needs

2020-05-25 Thread Remco Rijnders
On Sun, May 24, 2020 at 06:49:03PM -0700, Kevin wrote in <20200525014903.ga1...@afu.lan>: diff --git a/mutt_random.h b/mutt_random.h +#include +#include +#include +#include Mutt traditionally puts these inside the .c file. So I'd prefer to see them moved there. +extern void mutt_to_

Re: [PATCH 1/3] Use LFSR113 PRNG for mutt's internal random needs

2020-05-25 Thread Remco Rijnders
On Mon, May 25, 2020 at 04:24:41PM +0200, Oswald wrote in <20200525142441.GC855843@ugly>: Well, the idea for z4 is really to pick another seed than any other user running mutt on the same system would have. every process gets its own address space, so it will be the same in each process, unless

[PATCH] Remove support for OpenSSL <0.9.5

2020-05-29 Thread Remco Rijnders
The current code provides a workaround for the absence of RAND_status in OpenSSL versions before 0.9.5. The comments in the code indicate these versions have to be supported, but as these versions are now more than 20 years old, this no longer applies. Removing this support simplifies the code and

[PATCH] Use OpenSSL, GnuTLS, or LFSR113 PRNG for mutt's random needs

2020-05-29 Thread Remco Rijnders
mutt_random32() }; + + mutt_to_base64((unsigned char *) output_B64, (unsigned char *) randombits, +12, 17); +} diff --git a/mutt_random.h b/mutt_random.h new file mode 100644 index ..30724e72 --- /dev/null +++ b/mutt_random.h @@ -0,0 +1,24 @@ +/* + * Copyrigh

Re: [PATCH 1/3] Use LFSR113 PRNG for mutt's internal random needs

2020-05-29 Thread Remco Rijnders
On Mon, May 25, 2020 at 09:28:30AM -0700, Kevin wrote in <20200525162830.gd1...@afu.lan>: Remco, sorry I missed a few of those issues. In general you'll want to follow the pattern of other files: ... Got it (I hope)! I have made the necessary changes in message <20200529195152.5925-1-re...@w

Re: [PATCH] Remove support for OpenSSL <0.9.5

2020-05-29 Thread Remco Rijnders
On Fri, May 29, 2020 at 01:38:48PM -0700, Kevin wrote in <20200529203848.gd2...@afu.lan>: This also removes the check for RAND_egd, which we still want. Thank you for your patience Kevin, I know I am trying it! Remco From 07b1d1af4b431b26d32addd9a8ee2597cb7190a4 Mon Sep 17 00:00:00 2001 From:

Re: [PATCH] Change hardcoded subject of replies

2020-07-23 Thread Remco Rijnders
On Thu, Jul 23, 2020 at 09:44:18AM -0700, Kevin wrote in <20200723164418.gb235...@afu.lan>: On Thu, Jul 23, 2020 at 07:15:11PM +0300, Maxim Tarasov wrote: This affects prefilled subject of a reply to an email with an empty subject. --- -env->subject = safe_strdup ("Re: your mail"); +env

Re: Taking a break for a bit

2020-07-29 Thread Remco Rijnders
On Tue, Jul 28, 2020 at 01:12:24PM -0700, Kevin wrote in <20200728201224.ga148...@afu.lan>: Just a heads-up that I'm going to take a few weeks off from Mutt development. It's been consuming a large amount of my time, and I need some counterbalance to regain my perspective and get my motivation

Re: [PATCH] Support for overriding permissions of saved files

2020-08-18 Thread Remco Rijnders
On Mon, Aug 17, 2020 at 10:37:57PM -0500, Derek wrote in <20200818033757.gd28...@bladeshadow.org>: It's worth pointing out one additional point that I haven't: The data in an attachment might be considered sensitive by the person sending you the attachment, whereas to YOU it doesn't matter in th

Re: ncurses: keypad() required after endwin() again?

2021-01-18 Thread Remco Rijnders
On Mon, Jan 18, 2021 at 04:05:14PM -0800, Kevin wrote in : This is an ncurses question, but if I'm lucky Thomas Dickey might see it here. :-) Anyway, I'm wondering if 'keypad (stdscr, TRUE);' is technically required to be called again after an (temporary) endwin()? Mutt does this is a couple