[PATCH] Remove support for OpenSSL <0.9.5

2020-05-29 Thread Remco Rijnders
The current code provides a workaround for the absence of RAND_status in OpenSSL versions before 0.9.5. The comments in the code indicate these versions have to be supported, but as these versions are now more than 20 years old, this no longer applies. Removing this support simplifies the code and

[PATCH] Use OpenSSL, GnuTLS, or LFSR113 PRNG for mutt's random needs

2020-05-29 Thread Remco Rijnders
When mutt needs a random number (for example for naming the tmp files or generating a boundary for MIME attachments) it currently uses different implementation specific functions: random() and either lrand48() or rand() are used. Which one gets used in specific and the quality of its randomness is

Re: [PATCH 1/3] Use LFSR113 PRNG for mutt's internal random needs

2020-05-29 Thread Remco Rijnders
On Mon, May 25, 2020 at 09:28:30AM -0700, Kevin wrote in <20200525162830.gd1...@afu.lan>: Remco, sorry I missed a few of those issues. In general you'll want to follow the pattern of other files: ... Got it (I hope)! I have made the necessary changes in message <20200529195152.5925-1-re...@w

Re: [PATCH] Use OpenSSL, GnuTLS, or LFSR113 PRNG for mutt's random needs

2020-05-29 Thread Oswald Buddenhagen
On Fri, May 29, 2020 at 03:51:52PM -0400, Remco Rijnders wrote: When mutt is not configured with either of these two libraries, it will now use a built in PRNG function (the LFSR113 algorithm by Pierre L'Ecuyer) to generate high quality pseudo random numbers. fair enough, but you still should tr

Re: [PATCH] Remove support for OpenSSL <0.9.5

2020-05-29 Thread Kevin J. McCarthy
On Fri, May 29, 2020 at 03:49:19PM -0400, Remco Rijnders wrote: --- a/configure.ac +++ b/configure.ac @@ -813,7 +813,6 @@ AC_ARG_WITH(ssl, AS_HELP_STRING([--with-ssl@<:@=PFX@:>@],[Enable TLS support usi AC_MSG_ERROR([Unable to find SSL library]), [$crypto_libs]) LIBS="$

Re: [PATCH] Remove support for OpenSSL <0.9.5

2020-05-29 Thread Remco Rijnders
On Fri, May 29, 2020 at 01:38:48PM -0700, Kevin wrote in <20200529203848.gd2...@afu.lan>: This also removes the check for RAND_egd, which we still want. Thank you for your patience Kevin, I know I am trying it! Remco From 07b1d1af4b431b26d32addd9a8ee2597cb7190a4 Mon Sep 17 00:00:00 2001 From:

Re: [PATCH] Remove support for OpenSSL <0.9.5

2020-05-29 Thread Kevin J. McCarthy
On Fri, May 29, 2020 at 05:57:19PM -0400, Remco Rijnders wrote: On Fri, May 29, 2020 at 01:38:48PM -0700, Kevin wrote in <20200529203848.gd2...@afu.lan>: This also removes the check for RAND_egd, which we still want. Thank you for your patience Kevin, I know I am trying it! That's okay. It t

Re: [PATCH 1/3] Use LFSR113 PRNG for mutt's internal random needs

2020-05-29 Thread Kevin J. McCarthy
On Fri, May 29, 2020 at 03:58:35PM -0400, Remco Rijnders wrote: On Mon, May 25, 2020 at 09:28:30AM -0700, Kevin wrote in <20200525162830.gd1...@afu.lan>: Remco, sorry I missed a few of those issues. In general you'll want to follow the pattern of other files: ... Got it (I hope)! I have made