On Fri, May 29, 2020 at 03:58:35PM -0400, Remco Rijnders wrote:
On Mon, May 25, 2020 at 09:28:30AM -0700, Kevin wrote in <20200525162830.gd1...@afu.lan>:Remco, sorry I missed a few of those issues. In general you'll want to follow the pattern of other files:...Got it (I hope)!I have made the necessary changes in message <20200529195152.5925-1-re...@webconquest.com>. Furthermore, in that patch I have now also changed it to where we use the random numbers from OpenSSL/LibreSSL first, if compiled with SSL support, otherwise with random numbers from GnuTLS, if compiled with GnuTLS support, and only using this new algorithm in the absence of both these options.I am interested in hearing your thoughts.
I'll take a closer look, but honestly I would prefer that made as a separate patch so it can be considered separately. (In addition to Oswald's comments).
I think your comments in <XsvMOtX+QDTV/kA0@settler> make a good case for not putting crypto-level randomization into a PRNG function, and I would like to think about it before moving in that direction (for message-id's too).
-- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
