Alignment attribute

2019-04-14 Thread Gero Treuner
On Thu, Apr 11, 2019 at 07:43:46PM -0700, Kevin J. McCarthy wrote: > On Thu, Apr 11, 2019 at 10:08:56PM -0400, Aaron Schrab wrote: > > There are already a few uses of __attribute__ in the mutt code; mostly > > in `intl/` but also one in `monitor.c`. > The monitor.c use did get through on my review

Re: Alignment attribute

2019-04-14 Thread Kevin J. McCarthy
On Sun, Apr 14, 2019 at 11:14:05PM +0200, Gero Treuner wrote: Just drop that alignment? No, let's leave it. The monitor.c is currently linux-only, so I feel fairly comfortable gcc or clang will be in use. Additionally it is able to be de-configured, so there is a workaround if needed. Con

Re: Alignment attribute

2019-04-14 Thread Eike Rathke
Hi, On Sunday, 2019-04-14 15:18:40 -0700, Kevin J. McCarthy wrote: > On Sun, Apr 14, 2019 at 11:14:05PM +0200, Gero Treuner wrote: > > Just drop that alignment? > > No, let's leave it. Interested I took a glance and yes it should be kept. > > Considering that Mutt doesn't control alignment on

Re: Alignment attribute

2019-04-14 Thread Kevin J. McCarthy
On Mon, Apr 15, 2019 at 02:38:27AM +0200, Eike Rathke wrote: The reason is that some processor architectures can't access words like int or long on odd addresses and doing so would result in a violation. Thanks Eike, that makes sense. I appreciate the explanation. -- Kevin J. McCarthy GPG Fin