Re: [PATCH] Add additional error handling to safe_rename().

2018-08-29 Thread Derek Martin
On Tue, Aug 28, 2018 at 06:08:46PM -0700, Kevin J. McCarthy wrote: > > Though, it seems it leaves in the stat comparison if > > link() succeeds, which is superfluous (could cause needless > > performance hit on slow networked filesystems), and violates KISS and > > "Don't write code you don't need"

Re: [PATCH] Add additional error handling to safe_rename().

2018-08-29 Thread Kevin J. McCarthy
On Wed, Aug 29, 2018 at 12:16:14PM -0500, Derek Martin wrote: > So, I think the post-success stat() calls should should come out, and > I wouldn't bother using #if to remove it. I think it's clearly just a > bad idea to do that check there, and we should remove any trace of it > so that no one is