On Wed, Aug 29, 2018 at 12:16:14PM -0500, Derek Martin wrote: > So, I think the post-success stat() calls should should come out, and > I wouldn't bother using #if to remove it. I think it's clearly just a > bad idea to do that check there, and we should remove any trace of it > so that no one is tempted to put it back in at some point in the > future. But if you feel there's a reason to keep it I won't continue > to argue the point.
I've pulled it out, but for now I'll leave it in the #if0 with the compare_stat() call. I'll add a todo to completely yank it in the next development cycle though. > Sure. It's easy enough to address if a user hits it--probably worth > documenting (in the code) though, if nothing else. I've added a comment about that as a breadcrumb if needed in the future. Thanks again. -- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
