Re: safe_rename() and verifying the result of link(2)

2018-08-24 Thread Vincent Lefevre
On 2018-08-22 15:35:16 +0200, Steffen Nurpmeso wrote: > Vincent Lefevre wrote in <20180821230229.ga16...@zira.vinc17.org>: > |* It is not clear whether this has ever been usuful (nothing in > | comment or in the commit log). > > According to some statement on a list you are also subscribed to >

Re: safe_rename() and verifying the result of link(2)

2018-08-24 Thread Vincent Lefevre
On 2018-08-23 14:50:31 -0500, Derek Martin wrote: > The former (ignoring link's return value and always doing the stat > comparison) is probably safest for most users. The latter will > apparently be less problematic for SSHFS-like quirks, but as we saw > there's an SSHFS option that makes it work

Re: safe_rename() and verifying the result of link(2)

2018-08-24 Thread Steffen Nurpmeso
Vincent Lefevre wrote in <20180824091156.ga20...@zira.vinc17.org>: |On 2018-08-22 15:35:16 +0200, Steffen Nurpmeso wrote: |> Vincent Lefevre wrote in <20180821230229.ga16...@zira.vinc17.org>: |>|* It is not clear whether this has ever been usuful (nothing in |>| comment or in the commit log).

Re: safe_rename() and verifying the result of link(2)

2018-08-24 Thread Derek Martin
On Fri, Aug 24, 2018 at 11:35:50AM +0200, Vincent Lefevre wrote: > On 2018-08-23 14:50:31 -0500, Derek Martin wrote: > > The former (ignoring link's return value and always doing the stat > > comparison) is probably safest for most users. The latter will > > apparently be less problematic for SSHF