On 2018-08-23 14:50:31 -0500, Derek Martin wrote: > The former (ignoring link's return value and always doing the stat > comparison) is probably safest for most users. The latter will > apparently be less problematic for SSHFS-like quirks, but as we saw > there's an SSHFS option that makes it work without this behavior.
You have no proof of that. If I understand correctly, you suggest to ignore link's return value in all cases because of a potential race condition on some old system. But then, if you use the SSHFS option to disable hard links, so that Mutt will use rename() instead, then you also need to consider race conditions it can introduce... If you think that rename() is at least as good as the link() stuff, then safe_rename is useless: you can just use rename(). :-) -- Vincent Lefèvre <vinc...@vinc17.net> - Web: <https://www.vinc17.net/> 100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/> Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)
