Re: corrupted attachments

2017-06-13 Thread Vincent Lefevre
On 2017-06-12 18:13:58 -0500, Derek Martin wrote: > I'm not opposed to using libmagic for this, but I actually think the > heueristic code should be removed entirely from Mutt. Message bodies > should be assumed to be text, and attachments are assumed to be NOT > text, by virtue of them not being

Re: [Mutt] #3950: Prune unusable keys from PGP key selection menu

2017-06-13 Thread Mutt
#3950: Prune unusable keys from PGP key selection menu -+- Reporter: madduck | Owner: mutt-dev Type: | Status: new enhancement| Priority: major | Milestone: Componen

Re: [Mutt] #3950: Prune unusable keys from PGP key selection menu

2017-06-13 Thread Mutt
#3950: Prune unusable keys from PGP key selection menu -+- Reporter: madduck | Owner: mutt-dev Type: | Status: new enhancement| Priority: major | Milestone: Componen

Re: corrupted attachments

2017-06-13 Thread Andries E. Brouwer
On Mon, Jun 12, 2017 at 06:13:58PM -0500, Derek Martin wrote: > On Tue, Jun 06, 2017 at 02:03:34AM +0200, Andries E. Brouwer wrote: > > On Tue, Jun 06, 2017 at 09:15:23AM +1000, Cameron Simpson wrote: > > > On 05Jun2017 22:12, Andries E. Brouwer wrote: > > >> A moment ago I sent 8 images as attach

Re: corrupted attachments

2017-06-13 Thread Derek Martin
On Tue, Jun 13, 2017 at 09:11:24AM +0200, Vincent Lefevre wrote: > On 2017-06-12 18:13:58 -0500, Derek Martin wrote: > > I'm not opposed to using libmagic for this, but I actually think > > the heueristic code should be removed entirely from Mutt. Message > > bodies should be assumed to be text, a

majordomo

2017-06-13 Thread Andries E. Brouwer
On Tue, Jun 13, 2017 at 10:44:41AM -0500, Derek Martin wrote: [something I did not read] Just for your amusement: I sent an unsubscribe request to majord...@mutt.org with the line that it had told me to use when I subscribed. The following happened: - The following addresses had permanen

Re: corrupted attachments

2017-06-13 Thread Derek Martin
On Tue, Jun 13, 2017 at 08:12:36PM +0200, Andries E. Brouwer wrote: > Please read the bug report, and shut up if you have nothing helpful > to contribute. You apparently stopped reading before the part where I supplied a simple and efficient solution to the problem: On Mon, Jun 12, 2017 at 06:13:

Re: corrupted attachments

2017-06-13 Thread Martin Mares
Hello, world!\n > "Arbitrary text" has a MIME type and associated file extension; No, it does not. People use lots of different extensions for plain text files and also often no extension at all (e.g., "README" or "COPYING"). Using libmagic to detect the MIME type sounds reasonable, but inferrin

Re: corrupted attachments

2017-06-13 Thread Vincent Lefevre
On 2017-06-13 10:44:41 -0500, Derek Martin wrote: > On Tue, Jun 13, 2017 at 09:11:24AM +0200, Vincent Lefevre wrote: > > On 2017-06-12 18:13:58 -0500, Derek Martin wrote: > > > I'm not opposed to using libmagic for this, but I actually think > > > the heueristic code should be removed entirely from

Re: corrupted attachments

2017-06-13 Thread Vincent Lefevre
On 2017-06-13 23:14:49 +0200, Martin Mares wrote: > Using libmagic to detect the MIME type sounds reasonable, but inferring > anything from the file's extension (or lack thereof) sounds not. I don't think that libmagic is a good idea. It has too many false positives; by that, I mean that it can sa

Re: corrupted attachments

2017-06-13 Thread Vincent Lefevre
On 2017-06-14 00:18:44 +0200, Vincent Lefevre wrote: > 1. If the filename has a known file extension, then deduce the >MIME type from it in the usual way (/etc/mime.types system). On this point, according to the Mutt manual, Mutt currently does: When you add an attachment to your mail mess

Re: corrupted attachments

2017-06-13 Thread Derek Martin
On Wed, Jun 14, 2017 at 12:18:44AM +0200, Vincent Lefevre wrote: > I don't think that libmagic is a good idea. It has too many false > positives; by that, I mean that it can say that some file has > some specific MIME type (e.g. text/x-c) while it is actually > just text that may have some lines of

Re: corrupted attachments

2017-06-13 Thread Vincent Lefevre
On 2017-06-13 17:46:44 -0500, Derek Martin wrote: > On Wed, Jun 14, 2017 at 12:18:44AM +0200, Vincent Lefevre wrote: > > 2. If the file is valid UTF-8 and contains no blacklisted control > >characters (to be defined, but this should include null bytes), > >then MIME type = text/plain. > >