4 new changesets in mutt:
http://dev.mutt.org/hg/mutt/rev/bc5fb152e2ba
changeset: 6096:bc5fb152e2ba
branch: HEAD
tag: tip
user:Michael Elkins
date:Thu Aug 05 21:57:07 2010 -0700
summary: when parsing From_ lines in mmdf/mbox, the TZ should be computed
based on
Am 03.08.2010, 14:51 Uhr, schrieb Mutt:
#3410: Mutt crashes when two instances open the same mailbox
+---
Reporter: vext01 | Owner: me
Type: defect | Status: assigned
Priority: major | Milestone:
#3410: Mutt crashes when two instances open the same mailbox
+---
Reporter: vext01 | Owner: me
Type: defect | Status: assigned
Priority: major | Milestone:
Component: mutt|
# HG changeset patch
# User Matthias Andree
# Date 1250600058 -7200
# Branch HEAD
# Node ID a979f8e21063d62e686af37d73976290d07816f0
# Parent bc5fb152e2baa218a5f5941dc52fee493c767219
Update for new autoconf.
diff --git a/configure.ac b/configure.ac
--- a/configure.ac
+++ b/configure.ac
@@ -3,9 +
# HG changeset patch
# User Matthias Andree
# Date 1281081481 -7200
# Branch HEAD
# Node ID b757803be9260e0152098ee2a2be856a416d085e
# Parent a979f8e21063d62e686af37d73976290d07816f0
Unbreak X.509 SubjAltName checks,
regression in 6016:dc09812e63a3 that calls strlen on an SSL sk rather than
its
Am 29.06.2010, 20:10 Uhr, schrieb Mutt:
#3426: certificate validation fails with openssl
--+-
Reporter: ph030 | Owner: mutt-dev
Type: defect| Status: new
Priority: major | Mil
In this series there are two patches:
- one to update configure.ac to rid ourselves of some obsolete
constructs - RECOMMENDED
- one to fix a serious bug in SubjAltName X.509 (SSL/TLS) certificate
matching broken since the embedded NUL-workaround in rev 6016.
REQUIRED, fixes Ticket #3426.
P
#3426: certificate validation fails with openssl
--+-
Reporter: ph030 | Owner: mutt-dev
Type: defect| Status: new
Priority: major | Milestone:
Component: mutt
#2177: Message copied from mbox to maildir has wrong mtime if DST
-+--
Reporter: molotov...@…| Owner: mutt-dev
Type: defect | Status: closed
Priority: trivial
On Fri, Aug 06, 2010 at 09:37:40AM +0200, Matthias Andree wrote:
> Am 03.08.2010, 14:51 Uhr, schrieb Mutt:
>
> >#3410: Mutt crashes when two instances open the same mailbox
> >+---
> > Reporter: vext01 | Owner: me
> >
#3341: mutt 1.5.20 - case insensitive limits do not work
---+
Reporter: massysett | Owner: mutt-dev
Type: defect | Status: new
Priority: critical | Milestone:
Component: mutt
#3341: mutt 1.5.20 - case insensitive limits do not work
+---
Reporter: massysett | Owner: mutt-dev
Type: defect | Status: closed
Priority: critical | Milestone:
Component: mutt
#3438: naming scheme for recalled draft tempfiles
-+--
Reporter: balderdash | Owner: brendan
Type: enhancement | Status: new
Priority: minor| Milestone:
Component: IMAP
#3438: naming scheme for recalled draft tempfiles
-+--
Reporter: balderdash | Owner: brendan
Type: enhancement | Status: new
Priority: minor| Milestone: 1.6
Component: IMAP
#3426: certificate validation fails with openssl
-+--
Reporter: ph030 | Owner: mutt-dev
Type: defect | Status: closed
Priority: major | Milestone:
Component: mutt|
On Fri, Aug 06, 2010 at 09:58:41AM +0200, Matthias Andree wrote:
Unbreak X.509 SubjAltName checks,
regression in 6016:dc09812e63a3 that calls strlen on an SSL sk rather than
its string payload.
Thanks, applied. I made a small change to add a (char*) cast to squash the
compiler warning.
me
#1734: month localization inconsistency in browser
+---
Reporter: Alain Bench |Owner: mutt-dev
Type: defect | Status: closed
Priority: minor
#3406: folder_format %d should reference date_format
--+-
Reporter: rubix| Owner: me
Type: enhancement | Status: closed
Priority: trivial | Mil
#1932: Clash between Reply-To and alternates when replying
-+--
Reporter: vinc...@… | Owner: mutt-dev
Type: defect | Status: closed
Priority: minor | Milestone:
I had been able to build on opensolaris with changeset:
changeset: 5430:7cd85c18bfaf
branch: HEAD
tag: qparent
user:Michael Elkins
date:Sat Jul 31 08:21:33 2010 -0700
description:
Fix buffer underflow in expansion of format pipes. Add better
error de
Greetings,
I'm reviewing random compiler warnings.
mutt_socket_readln_d() gets size_t buflen as argument, but uses int as
iterator variable. There is a mismatch because int can never hold as much
as the unsigned size_t type, and there may be additional mismatches
between 32-bit int and 64-
# HG changeset patch
# User Matthias Andree
# Date 1281122572 -7200
# Branch HEAD
# Node ID 221f5024197fde2c43f5e83ecad562b2fb0796d2
# Parent 317338b0d4908fe45c9ef8c07ea3b5ef81f11bf8
Drop declaration for unused argv/argc parameters.
Fixes GCC warning with -Wextra.
diff --git a/md5.c b/md5.c
---
On Fri, Aug 06, 2010 at 02:34:35PM -0500, Will Fiveash wrote:
browser.c:168: error: `true' undeclared (first use in this function)
browser.c:168: error: (Each undeclared identifier is reported only once
browser.c:168: error: for each function it appears in.)
browser.c:174: error: `false' undeclar
On Fri, Aug 06, 2010 at 12:56:28PM -0700, Michael Elkins wrote:
> On Fri, Aug 06, 2010 at 02:34:35PM -0500, Will Fiveash wrote:
> >browser.c:168: error: `true' undeclared (first use in this function)
> >browser.c:168: error: (Each undeclared identifier is reported only once
> >browser.c:168: error:
#3158: CVE id CAN-2005-2351: less random temp file creation allows DOS
---+
Reporter: anto...@… | Owner: mutt-dev
Type: defect| Status: closed
Priority: minor | Mile
On Fri, Aug 06, 2010 at 09:41:38PM +0200, Matthias Andree wrote:
Drop declaration for unused argv/argc parameters.
Fixes GCC warning with -Wextra.
applied, thanks.
me
pgppjLgnHz46B.pgp
Description: PGP signature
#2304: reply / group reply behavior broken WRT $reply_to and $reply_self
-+--
Reporter: c...@… | Owner: mutt-dev
Type: defect | Status: new
I've picked out a few warnings and fixed them, often type confusion
around size_t vs. int, size_t vs. long, or unsigned vs. int.
# HG changeset patch
# User Matthias Andree
# Date 1281124734 -7200
# Branch HEAD
# Node ID 4bc65ed599ef817bb754e4edfeaadffda857e3f9
# Parent 73dd65f57f103c5f1fba175b4ee1ed8541ad5081
Fix comparison signedness warning.
diff --git a/pop_lib.c b/pop_lib.c
--- a/pop_lib.c
+++ b/pop_lib.c
@@ -498,7 +
# HG changeset patch
# User Matthias Andree
# Date 1281124626 -7200
# Branch HEAD
# Node ID 73dd65f57f103c5f1fba175b4ee1ed8541ad5081
# Parent 55eac87c65e021bf663875e931f2868491251d07
Ignore backup files ending in a tilde character.
diff --git a/.hgignore b/.hgignore
--- a/.hgignore
+++ b/.hgigno
# HG changeset patch
# User Matthias Andree
# Date 1281124790 -7200
# Branch HEAD
# Node ID 55667d213995788784043ab889d8ac1995fd2b37
# Parent 4bc65ed599ef817bb754e4edfeaadffda857e3f9
Fix comparison signedness warning.
diff --git a/gnupgparse.c b/gnupgparse.c
--- a/gnupgparse.c
+++ b/gnupgparse.c
# HG changeset patch
# User Matthias Andree
# Date 1281124462 -7200
# Branch HEAD
# Node ID 55eac87c65e021bf663875e931f2868491251d07
# Parent 151598faceaeab3c37f1de4274fc8324a88f27f5
Fix comparison signedness warnings.
diff --git a/pop_auth.c b/pop_auth.c
--- a/pop_auth.c
+++ b/pop_auth.c
@@ -17
# HG changeset patch
# User Matthias Andree
# Date 1281124356 -7200
# Branch HEAD
# Node ID fa6b3ce69655b50e1e8146dce3d4b83f040052fc
# Parent 38a8fa1d1b69727de8b8f4cba49b9cb949032691
Resolve if/else empty body ambiguity/warnings when compiling without DEBUG.
diff --git a/lib.h b/lib.h
--- a/lib.
# HG changeset patch
# User Matthias Andree
# Date 1281124898 -7200
# Branch HEAD
# Node ID 8bf3c2dac4545c2bfcdd411806c1f2b2442ac035
# Parent 55667d213995788784043ab889d8ac1995fd2b37
Fix comparison signedness warnings.
diff --git a/url.c b/url.c
--- a/url.c
+++ b/url.c
@@ -81,7 +81,7 @@
if
# HG changeset patch
# User Matthias Andree
# Date 1281124305 -7200
# Branch HEAD
# Node ID 38a8fa1d1b69727de8b8f4cba49b9cb949032691
# Parent caf6c2da0ec8a20b83bb951730ff53bfeffa0af2
Fix comparison signedness warnings.
diff --git a/mutt_ssl.c b/mutt_ssl.c
--- a/mutt_ssl.c
+++ b/mutt_ssl.c
@@ -76
# HG changeset patch
# User Matthias Andree
# Date 1281124286 -7200
# Branch HEAD
# Node ID caf6c2da0ec8a20b83bb951730ff53bfeffa0af2
# Parent bf13863e682ebab57683147787bd074844322218
Fix signedness warning.
diff --git a/status.c b/status.c
--- a/status.c
+++ b/status.c
@@ -209,7 +209,7 @@
# HG changeset patch
# User Matthias Andree
# Date 1281124373 -7200
# Branch HEAD
# Node ID 151598faceaeab3c37f1de4274fc8324a88f27f5
# Parent fa6b3ce69655b50e1e8146dce3d4b83f040052fc
Fix comparison signedness warnings.
diff --git a/buffy.c b/buffy.c
--- a/buffy.c
+++ b/buffy.c
@@ -456,7 +456,7 @
On 2010-08-06 23:33:29 +0200, Matthias Andree wrote:
> Fix comparison signedness warning.
>
> diff --git a/pop_lib.c b/pop_lib.c
> --- a/pop_lib.c
> +++ b/pop_lib.c
> @@ -498,7 +498,7 @@
> strfcpy (inbuf + lenbuf, p, sizeof (buf));
> pos += chunk;
>
> -if (chunk >= sizeof (buf))
>
#3439: Possible constraint violation or undefined behavior in mutt_srandom
(init.c)
+---
Reporter: vinc17 | Owner: mutt-dev
Type: defect | Status: new
Priority: major | Milestone:
Com
#3439: Possible constraint violation or undefined behavior in mutt_srandom
(init.c)
+---
Reporter: vinc17 | Owner: mutt-dev
Type: defect | Status: new
Priority: major | Milestone:
Com
#3439: Possible constraint violation or undefined behavior in mutt_srandom
(init.c)
+---
Reporter: vinc17 | Owner: mutt-dev
Type: defect | Status: new
Priority: major | Milestone:
Com
#3439: Possible constraint violation or undefined behavior in mutt_srandom
(init.c)
-+--
Reporter: vinc17 | Owner: mutt-dev
Type: defect | Status: closed
Priority: major | Milestone:
#3439: Possible constraint violation or undefined behavior in mutt_srandom
(init.c)
-+--
Reporter: vinc17 | Owner: mutt-dev
Type: defect | Status: closed
Priority: major | Milestone:
Alternate version of this patch to ensure the cast is safe.
# HG changeset patch
# User Michael Elkins
# Date 1281159058 25200
# Branch HEAD
# Node ID e1aa54051b30b4e733909608fd15aa269ab2c50a
# Parent 5b15d4d9627795c4ff95bf872049bd3be6078e6a
[mq]: mutt_ssl_sign_compare
diff -r 5b15d4d96277 -r
Alternate version with addition check to make sure cast is safe.
# HG changeset patch
# User Matthias Andree
# Date 1281124373 -7200
# Branch HEAD
# Node ID f6590ddfaf4f1317b85345156a62397f1b530213
# Parent 12ffab6683cd85ed8407683ef377f20798d126b4
Fix comparison signedness warnings.
diff -r 12
On Fri, Aug 06, 2010 at 11:49:24PM +0200, Vincent Lefevre wrote:
On 2010-08-06 23:33:29 +0200, Matthias Andree wrote:
-if (chunk >= sizeof (buf))
+if ((size_t)chunk >= sizeof (buf))
I would say that a signedness warning would be here a compiler bug
since with a simple variable range an
applied, thanks.
me
pgp93Fn7nddA5.pgp
Description: PGP signature
47 matches
Mail list logo
