4 new changesets in mutt:
http://dev.mutt.org/hg/mutt/rev/adaf24e4117d
changeset: 5601:adaf24e4117d
branch: HEAD
tag: tip
user:Erik Hovland
date:Mon Dec 15 23:45:37 2008 -0800
summary: Fix bad parentheses in stat rc
http://dev.mutt.org/hg/mutt/rev/2991ac6bc363
On Thursday, 04 December 2008 at 12:21, Erik Hovland wrote:
> I have access to a static analysis tool. And I happen to
> be a long time user of mutt. I would like to continue to be a user.
> So I ran the tool over HEAD to see what it found. It found a lot. But
> here are a few things that I am pret
On Friday, 05 December 2008 at 02:31, Vincent Lefevre wrote:
> On 2008-12-04 12:21:33 -0800, Erik Hovland wrote:
> > 4. Since getc returns int, the variable that stores it should be that type.
> >
> >If the variable that stores the return value of getc is smaller then
> >int (like a char i
>> I have access to a static analysis tool. And I happen to
>> be a long time user of mutt. I would like to continue to be a user.
>> So I ran the tool over HEAD to see what it found. It found a lot. But
>> here are a few things that I am pretty sure could be fixed with little
>> impact.
>
> Thanks
35 files changed, 88 deletions(-)
alias.c |1 -
attach.c |3 ---
buffy.c |1 -
color.c |1 -
commands.c |1 -
compose.c|1 -
crypt.c |7 ---
curs_main.c |4
flags.c |4
group.c |8
hcache.c |4
On Tuesday, December 16 at 01:48 PM, quoth Erik Hovland:
Some headers provide no useful symbols to the file that includes it.
This means that the header is optional. And since it is optional, then
removing it saves time (less for cpp to process) and space.
As a guy whose done a little bit of cr
> Anyway - how certain are you that those headers *never* provide useful
> symbols?
I am not certain at all that they are *never* useful. In fact, all I
know is that they
are not useful on RHEL 5.2 (my build platform).
The patch is meant to provide a starting point for cleaning up the headers and
On Tuesday, 16 December 2008 at 14:14, Erik Hovland wrote:
> > Anyway - how certain are you that those headers *never* provide useful
> > symbols?
>
> I am not certain at all that they are *never* useful. In fact, all I
> know is that they
> are not useful on RHEL 5.2 (my build platform).
>
> The
1 file changed, 5 insertions(+), 2 deletions(-)
sendlib.c |7 +--
# HG changeset patch
# User Erik Hovland
# Date 1229466703 28800
# Branch HEAD
# Node ID cc483a58bfbda95208eded019fe620297f31a76d
# Parent 94317019739335b9869b4e3f9c4cfef689dda58b
mutt_gen_msgid() allocates the msgid off o
On Fri, Dec 05, 2008 at 02:31:49AM +0100, Vincent Lefevre wrote:
> >h = (h * SOMEPRIME) % n;
> > - h = (h >= 0) ? h : h + n;
Unless either h or n is unsigned, the C language doesn't define
the sign of h % n.
So the deleted line is required to ensure the returned h is positive.
Davi
>> >h = (h * SOMEPRIME) % n;
>> > - h = (h >= 0) ? h : h + n;
>
> Unless either h or n is unsigned, the C language doesn't define
> the sign of h % n.
>
> So the deleted line is required to ensure the returned h is positive.
h is unsigned. So doing a h >= 0 will always evaluate true.
E
--
On Tuesday, 16 December 2008 at 14:33, Erik Hovland wrote:
> 1 file changed, 5 insertions(+), 2 deletions(-)
> sendlib.c |7 +--
>
>
> # HG changeset patch
> # User Erik Hovland
> # Date 1229466703 28800
> # Branch HEAD
> # Node ID cc483a58bfbda95208eded019fe620297f31a76d
> # Parent 9431
> We usually use the FREE macro instead of safe_free though.
> You might want to give check_sec.sh (in the repository) a
> whirl.
I noticed this idiom about 10 minutes after I sent the patch. Sorry
for missing it.
Thanks for the tip (and for applying the patch).
E
--
Erik Hovland
e...@hovland.
Forwarded from mutt-users (probably didn't do it right, though)
On Mon, Dec 15, 2008 at 11:21:22PM -0800, Brendan Cully wrote:
> On Wednesday, 10 December 2008 at 16:05, John J. Foster wrote:
> > On Sat, Dec 06, 2008 at 02:32:10PM -0700, John J. Foster wrote:
> > > I've noticed that when running 1
On Tuesday, 16 December 2008 at 13:48, Erik Hovland wrote:
> # HG changeset patch
> # User Erik Hovland
> # Date 1229463968 28800
> # Branch HEAD
> # Node ID f40ed4a28f4dc9d9728aa219fac5280cca9ebeda
> # Parent 42a16583ecc729bcd276e69e8ac17fdee23ef6ff
> Remove any optional headers
>
> Some header
On Thursday, 11 December 2008 at 10:10, Jeremie Le Hen wrote:
> Hi all,
>
> On Fri, Dec 05, 2008 at 04:34:56PM +0100, Jeremie Le Hen wrote:
> > On Fri, Dec 05, 2008 at 04:35:58PM +0100, Vincent Lefevre wrote:
> > > On 2008-12-05 16:28:55 +0100, Vincent Lefevre wrote:
> > > > Since 5517:4cc92c30543
On Friday, 28 November 2008 at 23:22, Jim Pryor wrote:
> I've been using mutt 1.5.18 (on Arch Linux, kernel 2.6.27.something).
> Just tried out mutt-hg, which I built using these settings:
>
> ./prepare --prefix=/usr --sysconfdir=/etc \
> --enable-pop --enable-imap --enable-smtp \
>
17 matches
Mail list logo
